Exit code fix #93

pkalever · 2018-07-06T12:22:49Z

No description provided.

pranithk · 2018-07-09T11:29:22Z

@pkalever Could you add a bit more details about what is the problem and how it addresses the problem?

pkalever · 2018-07-09T11:35:05Z

rpc/block_svc_routines.c

@@ -3783,6 +3782,7 @@ blockCreateCliFormatResponse(struct glfs *glfs, blockCreateCli *blk,
    blockFormatErrorResponse(CREATE_SRV, blk->json_resp, errCode,
                             GB_DEFAULT_ERRMSG, reply);
  }
+  reply->exit = errCode;


For the BUG raised, this line fixes the problem. Create exit code is not collected before, so fixing the code to collect the right exit code.

@pkalever If you look at the pull request/commit message it doesn't explain the problem what you encountered and how it is solving it. People generally do that when a patch is sent, otherwise the context will be forgotten after a few months. I just want you to capture that in the pull request.

@pkalever Thanks for the commit message. I am seeing similar issue in modify, resize, info. I think even in Delete we can move it to the end like you did here. Did you get a chance to check those as well? Am I missing some other detail?

Done, thanks!

pkalever · 2018-07-10T09:49:01Z

@pranithk I have updated the commit msg.

pkalever · 2018-07-11T14:59:12Z

@pranithk after fixing your review comments. I have tested create/info/list/modify (auth/size)/delete operations with and without json flag and validated the exit code for success paths. In all the cases I got exit code 0.

Thanks!

pranithk

Changes look okay, but the commit message still says create, instead of the wide range of cli operations for which it works now.

also tuned few logs to look more meaningful Reviewed-by: Pranith Kumar K <pkarampu@redhat.com> Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>

In version check failure paths, we are not updating the reply->exit variable. This patch will makesure about updating reply->exit value in all block*CliFormatResponse() functions, so that we never miss to update the right exitCode. Also improved some code for better readability. Reviewed-by: Pranith Kumar K <pkarampu@redhat.com> Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>

pkalever · 2018-07-11T15:58:33Z

@pranithk after fixing your review comments. I have tested create/info/list/modify (auth/size)/delete operations with and without json flag and validated the exit code for success paths. In all the cases I got exit code 0.

As discussed, In addition to this for -ve testing, have run create//modify (auth/size)/delete ops while "for i in {1..100000}; do pkill -9 targetcli; done" is running on one of the HA node with and without json flag, In all the cases I got exit code 255.

Will paste the output next to this comment.

Thanks!

pkalever · 2018-07-11T15:59:06Z

@pranithk here is the output:

[root@localhost gluster-block]# gluster-block create sample/block1 ha 3 192.168.124.6,192.168.124.163,192.168.124.217 1000000000 
failed to configure on 192.168.124.217 configure failed
RESULT:FAIL
[root@localhost gluster-block]# echo $?
255


[root@localhost gluster-block]# gluster-block create sample/block1 ha 3 192.168.124.6,192.168.124.163,192.168.124.217 1000000000  --json-pretty
{
  "RESULT":"FAIL",
  "errCode":255,
  "errMsg":"failed to configure on 192.168.124.217 configure failed"
}
[root@localhost gluster-block]# echo $?
255


[root@localhost gluster-block]# gluster-block modify sample/block1 auth enable                                                                                                                                     
IQN: iqn.2016-12.org.gluster-block:6cbd9abe-30a6-451a-acf4-6e9d50a2ae8c                                  
FAILED ON:  192.168.124.217                         
SUCCESSFUL ON:  192.168.124.6 192.168.124.163       
ROLLBACK SUCCESS ON:  192.168.124.6 192.168.124.163 
RESULT: FAIL                                        
[root@localhost gluster-block]# echo $?             
255                                                 


[root@localhost gluster-block]# gluster-block modify sample/block1 auth enable --json-pretty             
{                                                   
  "IQN":"iqn.2016-12.org.gluster-block:6cbd9abe-30a6-451a-acf4-6e9d50a2ae8c",                            
  "FAILED ON":[                                     
    "192.168.124.217"                               
  ],                                                
  "SUCCESSFUL ON":[                                 
    "192.168.124.6",                                
    "192.168.124.163"                               
  ],                                                
  "ROLLBACK SUCCESS ON":[                           
    "192.168.124.6",                                
    "192.168.124.163"                               
  ],                                                
  "RESULT":"FAIL"                                   
}                                                   
[root@localhost gluster-block]# echo $?             
255                                                 




[root@localhost gluster-block]# gluster-block modify sample/block1 size 2GiB
IQN: iqn.2016-12.org.gluster-block:6cbd9abe-30a6-451a-acf4-6e9d50a2ae8c
FAILED ON:  192.168.124.217
SUCCESSFUL ON:  192.168.124.6 192.168.124.163
RESULT: FAIL
[root@localhost gluster-block]# echo $?
255
[root@localhost gluster-block]# gluster-block modify sample/block1 size 2GiB --json-pretty
{
  "IQN":"iqn.2016-12.org.gluster-block:6cbd9abe-30a6-451a-acf4-6e9d50a2ae8c",
  "FAILED ON":[
    "192.168.124.217"
  ],
  "SUCCESSFUL ON":[
    "192.168.124.6",
    "192.168.124.163"
  ],
  "RESULT":"FAIL"
}
[root@localhost gluster-block]# echo $?
255
[root@localhost gluster-block]# 



[root@localhost gluster-block]# gluster-block delete sample/block1
FAILED ON:   192.168.124.217
SUCCESSFUL ON:   192.168.124.6 192.168.124.163
RESULT: FAIL
[root@localhost gluster-block]# echo $?
255
[root@localhost gluster-block]# gluster-block delete sample/block1 --json-pretty
{
  "FAILED ON":[
    "192.168.124.217"
  ],
  "RESULT":"FAIL"
}
[root@localhost gluster-block]# echo $?
255

pkalever requested a review from pranithk July 6, 2018 12:23

pkalever commented Jul 9, 2018

View reviewed changes

pkalever force-pushed the exitCode_fix branch from 959d55b to 0adabce Compare July 10, 2018 09:47

pkalever force-pushed the exitCode_fix branch from 0adabce to 6f2e04c Compare July 11, 2018 14:36

pranithk reviewed Jul 11, 2018

View reviewed changes

Prasanna Kumar Kalever added 2 commits July 11, 2018 21:03

logs: change remote version check call error log level to WARNING

8c252d8

also tuned few logs to look more meaningful Reviewed-by: Pranith Kumar K <pkarampu@redhat.com> Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>

pkalever force-pushed the exitCode_fix branch from 6f2e04c to b3efd00 Compare July 11, 2018 15:40

pranithk approved these changes Jul 11, 2018

View reviewed changes

pranithk merged commit dc0c037 into gluster:master Jul 11, 2018

pkalever deleted the exitCode_fix branch May 13, 2020 15:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Exit code fix #93

Exit code fix #93

pkalever commented Jul 6, 2018

pranithk commented Jul 9, 2018

pkalever Jul 9, 2018

pranithk Jul 9, 2018

pranithk Jul 10, 2018

pkalever Jul 11, 2018

pkalever commented Jul 10, 2018 •

edited

pkalever commented Jul 11, 2018

pranithk left a comment

pkalever commented Jul 11, 2018

pkalever commented Jul 11, 2018 •

edited

Exit code fix #93

Exit code fix #93

Conversation

pkalever commented Jul 6, 2018

pranithk commented Jul 9, 2018

pkalever Jul 9, 2018

Choose a reason for hiding this comment

pranithk Jul 9, 2018

Choose a reason for hiding this comment

pranithk Jul 10, 2018

Choose a reason for hiding this comment

pkalever Jul 11, 2018

Choose a reason for hiding this comment

pkalever commented Jul 10, 2018 • edited

pkalever commented Jul 11, 2018

pranithk left a comment

Choose a reason for hiding this comment

pkalever commented Jul 11, 2018

pkalever commented Jul 11, 2018 • edited

pkalever commented Jul 10, 2018 •

edited

pkalever commented Jul 11, 2018 •

edited