Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the ability to retrive the value of mount_ip from /etc/swift/fs.co... #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

prmarino1
Copy link

...nf to gluster-swift-gen-builders

this version of gluster-swift-gen-builders can get the value of mount_ip from /etc/swift/fs.conf then it detects if its a host name or IP if its a host name it resolves it because swift-ring-builder add fails if you use a host name.
The python socket.gethostbyname method is being used to resolve because even if the hostname is only in the /etc/hosts file, where by comparison the "host" command can only resolve names in a DNS and ignores the /etc/hosts file.

….conf to gluster-swift-gen-builders

this version of gluster-swift-gen-builders can get the value of mount_ip from /etc/swift/fs.conf then it detects if its a host name or IP if its a host name it resolves it because swift-ring-builder add fails if you use a host name.
The python socket.gethostbyname method is being used to resolve because even if the hostname is only in the /etc/hosts file, where by comparison the "host" command can only resolve names in a DNS and ignores the /etc/hosts file.
@prmarino1
Copy link
Author

accidentally originally garbed an old revision

@lpabon
Copy link

lpabon commented Sep 20, 2013

This is great! Thank you. The only issue is that this is just a public repo and we do not use github for our normal development workflow. Do you mind resubmitting the change using the development workflow as described here: https://github.com/gluster/gluster-swift/blob/master/doc/markdown/dev_guide.md

@prmarino1
Copy link
Author

sure
Ill do that later today when I get a chance.

On Fri, Sep 20, 2013 at 4:08 PM, Luis Pabon notifications@github.comwrote:

This is great! Thank you. The only issue is that this is just a public
repo and we do not use github for our normal development workflow. Do you
mind resubmitting the change using the development workflow as described
here:
https://github.com/gluster/gluster-swift/blob/master/doc/markdown/dev_guide.md


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-24837913
.

@prmarino1
Copy link
Author

It should be uploaded to Gerrit now topic
GET-MOUNT_IP-FOR-GEN-BUILDERS-SCRIPT

On Mon, Sep 23, 2013 at 9:43 AM, Paul Robert Marino prmarino1@gmail.comwrote:

sure
Ill do that later today when I get a chance.

On Fri, Sep 20, 2013 at 4:08 PM, Luis Pabon notifications@github.comwrote:

This is great! Thank you. The only issue is that this is just a public
repo and we do not use github for our normal development workflow. Do you
mind resubmitting the change using the development workflow as described
here:
https://github.com/gluster/gluster-swift/blob/master/doc/markdown/dev_guide.md


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-24837913
.

@lpabon
Copy link

lpabon commented Sep 23, 2013

I can't seem to find it. Do you mind sending the link to the review on
Gerrit?

  • Luis

On 09/23/2013 10:38 AM, Paul Robert Marino wrote:

It should be uploaded to Gerrit now topic
GET-MOUNT_IP-FOR-GEN-BUILDERS-SCRIPT

On Mon, Sep 23, 2013 at 9:43 AM, Paul Robert Marino
prmarino1@gmail.comwrote:

sure
Ill do that later today when I get a chance.

On Fri, Sep 20, 2013 at 4:08 PM, Luis Pabon
notifications@github.comwrote:

This is great! Thank you. The only issue is that this is just a public
repo and we do not use github for our normal development workflow.
Do you
mind resubmitting the change using the development workflow as
described
here:

https://github.com/gluster/gluster-swift/blob/master/doc/markdown/dev_guide.md


Reply to this email directly or view it on
GitHubhttps://github.com//pull/1#issuecomment-24837913
.


Reply to this email directly or view it on GitHub
#1 (comment).

@prmarino1
Copy link
Author

sorry about that it looks like the git review command choked on the change
log message and I didn't notice.

it should be there now

http://review.gluster.org/#/c/5992/

On Mon, Sep 23, 2013 at 3:51 PM, Luis Pabon notifications@github.comwrote:

I can't seem to find it. Do you mind sending the link to the review on
Gerrit?

  • Luis

On 09/23/2013 10:38 AM, Paul Robert Marino wrote:

It should be uploaded to Gerrit now topic
GET-MOUNT_IP-FOR-GEN-BUILDERS-SCRIPT

On Mon, Sep 23, 2013 at 9:43 AM, Paul Robert Marino
prmarino1@gmail.comwrote:

sure
Ill do that later today when I get a chance.

On Fri, Sep 20, 2013 at 4:08 PM, Luis Pabon
notifications@github.comwrote:

This is great! Thank you. The only issue is that this is just a public
repo and we do not use github for our normal development workflow.
Do you
mind resubmitting the change using the development workflow as
described
here:

https://github.com/gluster/gluster-swift/blob/master/doc/markdown/dev_guide.md


Reply to this email directly or view it on
GitHub<
https://github.com/gluster/gluster-swift/pull/1#issuecomment-24837913>

.


Reply to this email directly or view it on GitHub
#1 (comment).


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-24948775
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants