This repository has been archived by the owner on Mar 26, 2020. It is now read-only.
Improved test suite for self heal feature #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
ghost
assigned 
|
add to whitelist |
Madhu-1
reviewed
Dec 4, 2018
e2e/glustershd_test.go
Outdated
| } | ||
| } | ||
|
|
||
| f1, err := os.OpenFile(mntPath+"/file1.txt", os.O_RDWR, 0777) |
There was a problem hiding this comment.
Changed to Write only permissions.
aravindavk
reviewed
Dec 7, 2018
| for brick := range getBricksStatus { | ||
| if getBricksStatus[brick].Info.PeerID.String() == tc.gds[0].PeerID() { | ||
| process, err := os.FindProcess(getBricksStatus[brick].Pid) | ||
| r.Nil(err, fmt.Sprintf("failed to find bricks pid: %s", err)) |
There was a problem hiding this comment.
This test will be silently ignored if condition in line 75 is not satisfied. Add a test before for loop to check required number of BricksStatus with gds[0].PeerID
|
|
||
| for node := range healInfo { | ||
| if healInfo[node].Status == "Connected" { | ||
| r.NotNil(checkForPendingHeals(&healInfo[node])) |
There was a problem hiding this comment.
Same here. Add a test to see required number of nodes are in connected state
| r.Nil(err) | ||
| for node := range healInfo { | ||
| if healInfo[node].Status == "Connected" { | ||
| r.Nil(checkForPendingHeals(&healInfo[node])) |
Signed-off-by: Vishal Pandey <vpandey@redhat.com>
vpandey-RH
force-pushed
the
self-heal-e2e
branch
from
0d74fb4
to
683e20c
Compare
aravindavk
approved these changes
Dec 7, 2018
Madhu-1
approved these changes
Dec 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved test suite for heal process.
Signed-off-by: Vishal Pandey vpandey@redhat.com