This repository has been archived by the owner on Mar 26, 2020. It is now read-only.
Implement internal portmapper registry/service #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prashanth Pai <ppai@redhat.com>
|
This is complete enough to be reviewed but I intend to test this further. Please do not merge yet. |
samikshan
reviewed
Feb 23, 2017
pmap/pmap.go
Outdated
| return true | ||
| } | ||
|
|
||
| func registrySearchByPort(port int) string { |
There was a problem hiding this comment.
Yeah. I am not sure if this function is required. (even on GD1 side). If you still feel this is required, maybe returning a string[] instead would be better.
kshlm
suggested changes
Feb 24, 2017
pmap/pmap.go
Outdated
|
|
||
| for p := registry.LastAlloc; p >= registry.BasePort; p-- { | ||
|
|
||
| if registry.Ports[p].Type != GfPmapPortFree { |
There was a problem hiding this comment.
Did you mean to do something here?
pmap/pmap.go
Outdated
| if xprt != nil { | ||
| port = registrySearchByXprt(xprt, ptype) | ||
| if port != 0 { | ||
| goto REMOVE |
There was a problem hiding this comment.
Instead of using jumps, just make the REMOVE block a function and call it instead. Makes it cleaner.
Nobody in glusterd1 seems to use this call Signed-off-by: Prashanth Pai <ppai@redhat.com>
Signed-off-by: Prashanth Pai <ppai@redhat.com>
kshlm
approved these changes
Feb 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow bricks and mount process to talk to
glusterd2 about brick ports.
Signed-off-by: Prashanth Pai ppai@redhat.com