This repository has been archived by the owner on Mar 26, 2020. It is now read-only.
store: Correctly namespace etcd client #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All etcd interfaces that needed to be namespaced (KV, Lease, Watcher, Session) have been namespaced properly, for both remote store and embedded stores. As the etcd interfaces were not namespaced, some store operations happened out of namespace. Also, elasticetcd unintentionally got namespaced, causing some of its operations to happen in GD2s namespace.
There was a problem hiding this comment.
LGTM 👍
Have suggested one small change to a comment.
Checked the namespace now:
[ppai@gd2-1 ~]$ ETCDCTL_API=3 etcdctl get --prefix=true "" --endpoints=[127.0.0.1:2479]
elastic/election/3ee9604a56a00504
bffffede-1be5-4987-8989-929cb2255eaa
elastic/nominees/bffffede-1be5-4987-8989-929cb2255eaa
http://127.0.0.1:2480
elastic/volunteers/bffffede-1be5-4987-8989-929cb2255eaa
http://127.0.0.1:2480
gluster-9555d7aa-98c2-48cf-8d35-ccaf28181e85/alive/bffffede-1be5-4987-8989-929cb2255eaa
gluster-9555d7aa-98c2-48cf-8d35-ccaf28181e85/peers/bffffede-1be5-4987-8989-929cb2255eaa
{"ID":"bffffede-1be5-4987-8989-929cb2255eaa","Name":"gd2-1","Addresses":["127.0.0.1:24008"]}| lease := namespace.NewLease(oc.Lease, namespaceKey) | ||
| watcher := namespace.NewWatcher(oc.Watcher, namespaceKey) | ||
|
|
||
| // Create a new session (lease kept alive for the lifetime of a client) |
There was a problem hiding this comment.
This comment belongs just before the call to concurrency.NewSession
There was a problem hiding this comment.
Nope. It's in the right place. The two blocks below together create the proper new session.
prashanthpai
approved these changes
Dec 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All etcd interfaces that needed to be namespaced (KV, Lease, Watcher,
Session) have been namespaced properly, for both remote store and
embedded stores.
As the etcd interfaces were not namespaced, some store operations
happened out of namespace. Also, elasticetcd unintentionally got
namespaced, causing some of its operations to happen in GD2s namespace.