New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update upgrade guide with instructions for glustereventsd #410
Update upgrade guide with instructions for glustereventsd #410
Conversation
Upgrade guide did not specify stopping and restarting glustereventsd and these instructions are now added to the 3.12 and 4.1 upgrade guides, as these are the current supported releases. Signed-off-by: ShyamsundarR <srangana@redhat.com>
Signed-off-by: ShyamsundarR <srangana@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor set of review comments around rephrasing parts of the content
@@ -42,18 +43,23 @@ This procedure involves upgrading **one server at a time**, while keeping the vo | |||
#gluster volume status | |||
``` | |||
|
|||
7. Self-heal all gluster volumes by running | |||
7. Start glustereventsd service (if it was enabled before), either using the command below, or through other means, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the glustereventsd service was previously enabled, it is required to start it using the commands below, or, through other means
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
#systemctl start glustereventsd | ||
``` | ||
|
||
8. Self-heal all gluster volumes by running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invoke self-heal on all the gluster volumes by running
```sh | ||
#for i in `gluster volume list`; do gluster volume heal $i; done | ||
``` | ||
|
||
8. Ensure that there is no heal backlog by running the below command for all volumes | ||
9. Ensure that there is no heal backlog by running the below command for all volumes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify that there are no heal backlog by running the command for all the volumes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
```sh | ||
#gluster volume heal <volname> info | ||
``` | ||
> NOTE: If there is a heal backlog, wait till the backlog is empty, or the backlog does not have any entries needing a sync to the just upgraded server, before proceeding to upgrade the next server in the pool | ||
> **NOTE:** If there is a heal backlog, wait till the backlog is empty, or the backlog does not have any entries needing a sync to the just upgraded server, before proceeding to upgrade the next server in the pool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before proceeding to upgrade the next server in the pool it is recommended to check the heal backlog. If there is a heal backlog, it is recommended to wait until the backlog is empty, or, the backlog does not contain any entries requiring a sync to the just upgraded server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -84,7 +91,12 @@ This procedure involves cluster downtime and during the upgrade window, clients | |||
#gluster volume status | |||
``` | |||
|
|||
7. Restart any gfapi based application stopped previously in step (2) | |||
7. Start glustereventsd service (if it was enabled before), either using the command below, or through other means, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the glustereventsd service was previously enabled, it is required to start it using the commands below, or, through other means
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
docs/Upgrade-Guide/upgrade_to_4.1.md
Outdated
@@ -84,7 +91,12 @@ This procedure involves cluster downtime and during the upgrade window, clients | |||
#gluster volume status | |||
``` | |||
|
|||
7. Restart any gfapi based application stopped previously in step (2) | |||
7. Start glustereventsd service (if it was enabled before), either using the command below, or through other means, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the glustereventsd service was previously enabled, it is required to start it using the commands below, or, through other means
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
docs/Upgrade-Guide/upgrade_to_4.1.md
Outdated
```sh | ||
#gluster volume heal <volname> info | ||
``` | ||
> NOTE: If there is a heal backlog, wait till the backlog is empty, or the backlog does not have any entries needing a sync to the just upgraded server, before proceeding to upgrade the next server in the pool | ||
> **NOTE:** If there is a heal backlog, wait till the backlog is empty, or the backlog does not have any entries needing a sync to the just upgraded server, before proceeding to upgrade the next server in the pool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before proceeding to upgrade the next server in the pool it is recommended to check the heal backlog. If there is a heal backlog, it is recommended to wait until the backlog is empty, or, the backlog does not contain any entries requiring a sync to the just upgraded server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
docs/Upgrade-Guide/upgrade_to_4.1.md
Outdated
```sh | ||
#for i in `gluster volume list`; do gluster volume heal $i; done | ||
``` | ||
|
||
8. Ensure that there is no heal backlog by running the below command for all volumes | ||
9. Ensure that there is no heal backlog by running the below command for all volumes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify that there are no heal backlog by running the command for all the volumes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
docs/Upgrade-Guide/upgrade_to_4.1.md
Outdated
#systemctl start glustereventsd | ||
``` | ||
|
||
8. Self-heal all gluster volumes by running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invoke self-heal on all the gluster volumes by running
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Addresses review comments in the previous commit. Signed-off-by: ShyamsundarR <srangana@redhat.com>
I have verified that @sankarshanmukhopadhyay's comments have been addressed. |
Upgrade guide did not specify stopping and restarting glustereventsd
and these instructions are now added to the 3.12 and 4.1 upgrade
guides, as these are the current supported releases.
Signed-off-by: ShyamsundarR srangana@redhat.com