Expose errors to exceptions #7
Conversation
|
This sounds like a good idea. 😄 (Note - I'm not a code reviewer for this project) |
|
@Alphadelta14 This looks great! Thank you for the PR. You fixed BZ 1196161. This github repo is only a mirror and all our development happens over Gluster Gerrit (http://review.gluster.org/#/q/project:libgfapi-python). It would be really nice if you could send this change to Gerrit instead for easier review. This way you can continue to contribute by following the normal workflow followed by the project. However, if you do not have time for the same, I can do it for you. Let me know. Thanks! |
|
The Development Workflow: https://github.com/gluster/libgfapi-python/blob/master/doc/markdown/dev_guide.md |
Change-Id: I81bc8cf14fe6fd742c59052fda36dd6a8d406d71
Alphadelta14
force-pushed
the
alpha/expose-errno
branch
from
8c5e66f
to
5185488
Compare
|
@prashanthpai Thank you for your patience. I have re-submitted for review on Gerrit. |
Ensure that the errors raised have some meaning to them. There was an issue where
get_errnowould always return 0. This fixes those issues.