Fix mac dev build #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mac stat command is different from one in linux https://ss64.com/osx/stat.html
|
I forgot to check the existing PRs before writing my own and just realized that this PR is the subset of #17. I can confirm that the mac command seems fine, although |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OS X uses a different
statcommand. From what I can tell,stat -f %m $fileshould be the equivalent tostat -c %Y $file. This PR detects the OS, and choose which stat command to use.Keep in mind that I only tested it on the mac. There shouldn't be any side effects in linux, but I haven't tested it.
man OS X stat
man linux stat
Checklist:
Please replace the space inside the brackets with an x and fill out the ellipses if the following items apply: