Add sanity check to tell us if we're using log::warn! directly

gluwa · Jan 6, 2023 · b24784d · b24784d
1 parent 44aaaa1
commit b24784d
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -30,6 +30,10 @@ jobs:
         run: |
           ./scripts/check-parity-bw-extrinsics-benchmarks-weights.sh
 
+      - name: Check for direct usage of log::warn vs. warn_or_panic in migrations
+        run: |
+          ./scripts/check-usage-of-log-warn.sh
+
   fmt:
     name: Rustfmt
     runs-on: ubuntu-latest

diff --git a/scripts/check-usage-of-log-warn.sh b/scripts/check-usage-of-log-warn.sh
@@ -0,0 +1,14 @@
+#!/bin/bash
+
+set -xeuo pipefail
+
+# shellcheck disable=SC2038
+OUTPUT=$(find . -wholename "*/migrations/*.rs" | xargs grep "log::warn" || true)
+if [ -n "$OUTPUT" ]; then
+    echo "FAIL"
+    echo "$OUTPUT"
+    exit 1
+fi
+
+echo "PASS"
+exit 0