Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testnet branch #1134

Merged
merged 27 commits into from
Jun 15, 2023
Merged

Update testnet branch #1134

merged 27 commits into from
Jun 15, 2023

Conversation

nathanwhit
Copy link
Contributor

@nathanwhit nathanwhit commented Jun 15, 2023

Description of proposed changes

Updates testnet branch with latest changes (new PoS testnet chainspec + CLI fixes)


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@codecov-commenter
Copy link

Codecov Report

Merging #1134 (7e85be2) into testnet (0cc83df) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           testnet    #1134   +/-   ##
========================================
  Coverage    74.62%   74.62%           
========================================
  Files           74       74           
  Lines        10686    10686           
========================================
  Hits          7974     7974           
  Misses        2712     2712           
Impacted Files Coverage Δ
node/src/chain_spec.rs 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

For full LLVM coverage report click here!

@AdaJane AdaJane requested review from pLabarta and AdaJane June 15, 2023 19:55
AdaJane
AdaJane previously approved these changes Jun 15, 2023
pLabarta
pLabarta previously approved these changes Jun 15, 2023
@AdaJane AdaJane enabled auto-merge (squash) June 15, 2023 20:24
@github-actions github-actions bot dismissed stale reviews from pLabarta and AdaJane via dabb9eb June 15, 2023 20:32
@nathanwhit nathanwhit disabled auto-merge June 15, 2023 21:00
@nathanwhit nathanwhit enabled auto-merge (rebase) June 15, 2023 21:01
@nathanwhit nathanwhit disabled auto-merge June 15, 2023 21:01
@nathanwhit nathanwhit merged commit 84b2342 into testnet Jun 15, 2023
1 check passed
@nathanwhit nathanwhit deleted the update-testnet-2.222.1 branch June 15, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants