Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get metadata from creditcoin-node before rebuilding typedefs in CI #768

Merged
merged 2 commits into from Nov 14, 2022
Merged

Get metadata from creditcoin-node before rebuilding typedefs in CI #768

merged 2 commits into from Nov 14, 2022

Conversation

atodorov
Copy link
Collaborator

Description of proposed changes:

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@github-actions
Copy link

For full LLVM coverage report click here!

@atodorov atodorov assigned nathanwhit and unassigned nathanwhit Nov 10, 2022
@nathanwhit nathanwhit merged commit 8c80f5b into dev Nov 14, 2022
@nathanwhit nathanwhit deleted the fix-auto-update-in-ci branch November 14, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanwhit nathanwhit nathanwhit approved these changes

@CAGS295 CAGS295 CAGS295 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atodorov @nathanwhit @CAGS295