Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSUB-335: Remove hard coded accounts for Alice & Bob #805

Merged
merged 6 commits into from
Dec 14, 2022
Merged

CSUB-335: Remove hard coded accounts for Alice & Bob #805

merged 6 commits into from
Dec 14, 2022

Conversation

atodorov
Copy link
Collaborator

@atodorov atodorov commented Dec 5, 2022

Description of proposed changes:

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

For full LLVM coverage report click here!

@atodorov atodorov force-pushed the remove_hard_coded_accounts branch 2 times, most recently from db966cc to bc44e33 Compare December 5, 2022 16:48
@atodorov atodorov marked this pull request as ready for review December 5, 2022 17:37
@atodorov atodorov requested review from nathanwhit and CAGS295 and removed request for nathanwhit December 5, 2022 17:37
CAGS295
CAGS295 previously approved these changes Dec 6, 2022
View reviewed changes
creditcoin-js/src/testUtils.ts Outdated Show resolved Hide resolved
integration-tests/src/globalSetup.ts Outdated Show resolved Hide resolved
integration-tests/src/test/register-currency.test.ts Outdated Show resolved Hide resolved
integration-tests/src/test/register-address.test.ts Outdated Show resolved Hide resolved
@atodorov atodorov requested a review from CAGS295 December 6, 2022 14:24
CAGS295
CAGS295 previously approved these changes Dec 6, 2022
View reviewed changes
@atodorov atodorov mentioned this pull request Dec 8, 2022
Merged
@atodorov atodorov merged commit cb8f15c into dev Dec 14, 2022
@atodorov atodorov deleted the remove_hard_coded_accounts branch December 14, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanwhit nathanwhit nathanwhit approved these changes

@CAGS295 CAGS295 CAGS295 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atodorov @nathanwhit @CAGS295