Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSUB-358 Runtime-utils #828

Merged
merged 4 commits into from
Jan 3, 2023
Merged

CSUB-358 Runtime-utils #828

merged 4 commits into from
Jan 3, 2023

Conversation

CAGS295
Copy link
Contributor

@CAGS295 CAGS295 commented Dec 21, 2022

Description of proposed changes:

Decouple externalities utils from offchain-task-scheduler. I picked offchain-task-scheduler instead of creditcoin's impl arbitrarily. I this PR passes we need to update Creditcoin's.

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

atodorov
atodorov requested changes Dec 21, 2022
View reviewed changes
Copy link
Collaborator

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requested, otherwise looks good to me.

test/runtime-utils/Cargo.toml Show resolved Hide resolved
@CAGS295 CAGS295 force-pushed the feature/CSUB-358 branch 2 times, most recently from 704fc96 to 9249cd9 Compare December 23, 2022 20:45
@CAGS295 CAGS295 marked this pull request as ready for review December 23, 2022 20:47
@github-actions
Copy link

For full LLVM coverage report click here!

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2022 •
edited
Loading

Codecov Report

Merging #828 (c55cc1d) into dev (9424d73) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #828      +/-   ##
==========================================
+ Coverage   78.06%   78.10%   +0.03%     
==========================================
  Files          66       67       +1     
  Lines       10601    10608       +7     
==========================================
+ Hits         8276     8285       +9     
+ Misses       2325     2323       -2
Impacted Files Coverage Δ
runtime/src/lib.rs 24.25% <ø> (+0.61%) ⬆️
pallets/offchain-task-scheduler/src/authority.rs 100.00% <100.00%> (ø)
pallets/offchain-task-scheduler/src/mock/utils.rs 100.00% <100.00%> (ø)
pallets/offchain-task-scheduler/src/ocw/nonce.rs 99.37% <100.00%> (ø)
pallets/offchain-task-scheduler/src/ocw/tests.rs 100.00% <100.00%> (ø)
test/runtime-utils/src/lib.rs 100.00% <100.00%> (ø)
test/runtime-utils/src/pool.rs 100.00% <100.00%> (ø)
node/src/main.rs 16.66% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

nathanwhit
nathanwhit suggested changes Dec 24, 2022
View reviewed changes
Copy link
Contributor

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nightly feature flag seems unnecessary (maybe a mistake?), but looks good otherwise

test/runtime-utils/src/lib.rs Outdated Show resolved Hide resolved
test/runtime-utils/src/lib.rs Outdated Show resolved Hide resolved
atodorov
atodorov requested changes Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase to resolve conflicts, otherwise looks good to me.

@CAGS295 CAGS295 requested a review from atodorov January 3, 2023 17:00
@CAGS295 CAGS295 merged commit fb56e12 into dev Jan 3, 2023
@CAGS295 CAGS295 deleted the feature/CSUB-358 branch January 3, 2023 19:20
atodorov pushed a commit that referenced this pull request Jan 5, 2023
@CAGS295 @atodorov
CSUB-358 Runtime-utils (#828)
265cec5 
* decouple extension builder

* add runtime-utils and test client to dependabot

* bump version

* Auto-update creditcoin-js type definitions

Co-authored-by: Carlos Gutierrez <cg@pop-os.localdomain>
Co-authored-by: gluwa-bot <creditcoin@gluwa.com>
atodorov pushed a commit that referenced this pull request Jan 12, 2023
@CAGS295 @atodorov
CSUB-358 Runtime-utils (#828)
44370d1 
* decouple extension builder

* add runtime-utils and test client to dependabot

* bump version

* Auto-update creditcoin-js type definitions

Co-authored-by: Carlos Gutierrez <cg@pop-os.localdomain>
Co-authored-by: gluwa-bot <creditcoin@gluwa.com>
atodorov pushed a commit that referenced this pull request Jan 13, 2023
@CAGS295 @atodorov
CSUB-358 Runtime-utils (#828)
eb66e38 
* decouple extension builder

* add runtime-utils and test client to dependabot

* bump version

* Auto-update creditcoin-js type definitions

Co-authored-by: Carlos Gutierrez <cg@pop-os.localdomain>
Co-authored-by: gluwa-bot <creditcoin@gluwa.com>
atodorov pushed a commit that referenced this pull request Jan 13, 2023
@CAGS295 @atodorov
CSUB-358 Runtime-utils (#828)
ae0634b 
* decouple extension builder

* add runtime-utils and test client to dependabot

* bump version

* Auto-update creditcoin-js type definitions

Co-authored-by: Carlos Gutierrez <cg@pop-os.localdomain>
Co-authored-by: gluwa-bot <creditcoin@gluwa.com>
atodorov pushed a commit that referenced this pull request Jan 17, 2023
@CAGS295 @atodorov
CSUB-358 Runtime-utils (#828)
81225cb 
* decouple extension builder

* add runtime-utils and test client to dependabot

* bump version

* Auto-update creditcoin-js type definitions

Co-authored-by: Carlos Gutierrez <cg@pop-os.localdomain>
Co-authored-by: gluwa-bot <creditcoin@gluwa.com>
atodorov pushed a commit that referenced this pull request Jan 18, 2023
@CAGS295 @atodorov
CSUB-358 Runtime-utils (#828)
6be819e 
* decouple extension builder

* add runtime-utils and test client to dependabot

* bump version

* Auto-update creditcoin-js type definitions

Co-authored-by: Carlos Gutierrez <cg@pop-os.localdomain>
Co-authored-by: gluwa-bot <creditcoin@gluwa.com>
atodorov pushed a commit that referenced this pull request Jan 20, 2023
@CAGS295 @atodorov
CSUB-358 Runtime-utils (#828)
9050886 
* decouple extension builder

* add runtime-utils and test client to dependabot

* bump version

* Auto-update creditcoin-js type definitions

Co-authored-by: Carlos Gutierrez <cg@pop-os.localdomain>
Co-authored-by: gluwa-bot <creditcoin@gluwa.com>
atodorov pushed a commit that referenced this pull request Jan 31, 2023
@CAGS295 @atodorov
CSUB-358 Runtime-utils (#828)
96230c9 
* decouple extension builder

* add runtime-utils and test client to dependabot

* bump version

* Auto-update creditcoin-js type definitions

Co-authored-by: Carlos Gutierrez <cg@pop-os.localdomain>
Co-authored-by: gluwa-bot <creditcoin@gluwa.com>
atodorov pushed a commit that referenced this pull request Feb 2, 2023
@CAGS295 @atodorov
CSUB-358 Runtime-utils (#828)
fa826c5 
* decouple extension builder

* add runtime-utils and test client to dependabot

* bump version

* Auto-update creditcoin-js type definitions

Co-authored-by: Carlos Gutierrez <cg@pop-os.localdomain>
Co-authored-by: gluwa-bot <creditcoin@gluwa.com>
atodorov pushed a commit that referenced this pull request Feb 10, 2023
@CAGS295 @atodorov
CSUB-358 Runtime-utils (#828)
29728df 
* decouple extension builder

* add runtime-utils and test client to dependabot

* bump version

* Auto-update creditcoin-js type definitions

Co-authored-by: Carlos Gutierrez <cg@pop-os.localdomain>
Co-authored-by: gluwa-bot <creditcoin@gluwa.com>
atodorov pushed a commit that referenced this pull request Feb 10, 2023
@CAGS295 @atodorov
CSUB-358 Runtime-utils (#828)
0a9cc52 
* decouple extension builder

* add runtime-utils and test client to dependabot

* bump version

* Auto-update creditcoin-js type definitions

Co-authored-by: Carlos Gutierrez <cg@pop-os.localdomain>
Co-authored-by: gluwa-bot <creditcoin@gluwa.com>
atodorov pushed a commit that referenced this pull request Feb 10, 2023
@CAGS295 @atodorov
CSUB-358 Runtime-utils (#828)
069cb8d 
* decouple extension builder

* add runtime-utils and test client to dependabot

* bump version

* Auto-update creditcoin-js type definitions

Co-authored-by: Carlos Gutierrez <cg@pop-os.localdomain>
Co-authored-by: gluwa-bot <creditcoin@gluwa.com>
atodorov pushed a commit that referenced this pull request Feb 22, 2023
@CAGS295 @atodorov
CSUB-358 Runtime-utils (#828)
046b838 
* decouple extension builder

* add runtime-utils and test client to dependabot

* bump version

* Auto-update creditcoin-js type definitions

Co-authored-by: Carlos Gutierrez <cg@pop-os.localdomain>
Co-authored-by: gluwa-bot <creditcoin@gluwa.com>
atodorov pushed a commit that referenced this pull request Apr 3, 2023
@CAGS295 @atodorov
CSUB-358 Runtime-utils (#828)
dd39cf3 
* decouple extension builder

* add runtime-utils and test client to dependabot

* bump version

* Auto-update creditcoin-js type definitions

Co-authored-by: Carlos Gutierrez <cg@pop-os.localdomain>
Co-authored-by: gluwa-bot <creditcoin@gluwa.com>
atodorov pushed a commit that referenced this pull request Apr 13, 2023
@CAGS295 @atodorov
CSUB-358 Runtime-utils (#828)
e9b0ae2 
* decouple extension builder

* add runtime-utils and test client to dependabot

* bump version

* Auto-update creditcoin-js type definitions

Co-authored-by: Carlos Gutierrez <cg@pop-os.localdomain>
Co-authored-by: gluwa-bot <creditcoin@gluwa.com>
atodorov pushed a commit that referenced this pull request Apr 20, 2023
@CAGS295 @atodorov
CSUB-358 Runtime-utils (#828)
38bb6d0 
* decouple extension builder

* add runtime-utils and test client to dependabot

* bump version

* Auto-update creditcoin-js type definitions

Co-authored-by: Carlos Gutierrez <cg@pop-os.localdomain>
Co-authored-by: gluwa-bot <creditcoin@gluwa.com>
atodorov pushed a commit that referenced this pull request Apr 21, 2023
@CAGS295 @atodorov
CSUB-358 Runtime-utils (#828)
0a41953 
* decouple extension builder

* add runtime-utils and test client to dependabot

* bump version

* Auto-update creditcoin-js type definitions

Co-authored-by: Carlos Gutierrez <cg@pop-os.localdomain>
Co-authored-by: gluwa-bot <creditcoin@gluwa.com>
atodorov pushed a commit that referenced this pull request Apr 25, 2023
@CAGS295 @atodorov
CSUB-358 Runtime-utils (#828)
e6e73a4 
* decouple extension builder

* add runtime-utils and test client to dependabot

* bump version

* Auto-update creditcoin-js type definitions

Co-authored-by: Carlos Gutierrez <cg@pop-os.localdomain>
Co-authored-by: gluwa-bot <creditcoin@gluwa.com>
atodorov pushed a commit that referenced this pull request Apr 28, 2023
@CAGS295 @atodorov
CSUB-358 Runtime-utils (#828)
1217eb3 
* decouple extension builder

* add runtime-utils and test client to dependabot

* bump version

* Auto-update creditcoin-js type definitions

Co-authored-by: Carlos Gutierrez <cg@pop-os.localdomain>
Co-authored-by: gluwa-bot <creditcoin@gluwa.com>
atodorov pushed a commit that referenced this pull request May 1, 2023
@CAGS295 @atodorov
CSUB-358 Runtime-utils (#828)
8699044 
* decouple extension builder

* add runtime-utils and test client to dependabot

* bump version

* Auto-update creditcoin-js type definitions

Co-authored-by: Carlos Gutierrez <cg@pop-os.localdomain>
Co-authored-by: gluwa-bot <creditcoin@gluwa.com>
atodorov pushed a commit that referenced this pull request May 4, 2023
@CAGS295 @atodorov
CSUB-358 Runtime-utils (#828)
2653b6b 
* decouple extension builder

* add runtime-utils and test client to dependabot

* bump version

* Auto-update creditcoin-js type definitions

Co-authored-by: Carlos Gutierrez <cg@pop-os.localdomain>
Co-authored-by: gluwa-bot <creditcoin@gluwa.com>
nathanwhit pushed a commit that referenced this pull request Jun 7, 2023
@CAGS295 @nathanwhit
CSUB-358 Runtime-utils (#828)
c836266 
* decouple extension builder

* add runtime-utils and test client to dependabot

* bump version

* Auto-update creditcoin-js type definitions

Co-authored-by: Carlos Gutierrez <cg@pop-os.localdomain>
Co-authored-by: gluwa-bot <creditcoin@gluwa.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atodorov atodorov atodorov approved these changes

@nathanwhit nathanwhit nathanwhit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CAGS295 @codecov-commenter @atodorov @nathanwhit