-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSUB-336 weighted VRFs #831
Conversation
8637417
to
9fb4616
Compare
498f904
to
edc74b6
Compare
For full LLVM coverage report click here! |
Codecov Report
@@ Coverage Diff @@
## dev #831 +/- ##
==========================================
+ Coverage 78.26% 78.45% +0.19%
==========================================
Files 68 68
Lines 10724 10856 +132
==========================================
+ Hits 8393 8517 +124
- Misses 2331 2339 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ead5740
to
df6f526
Compare
9350348
to
dd06919
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes requested.
I think I need some more context here before I can review the tests further.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes to names of variables to make the tests more intuitive to understand.
219d8f3
to
e03fa5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass at review, just have a few questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of proposed changes:
This is an early implementation of the basics. I will be rebasing without notice until the interface is stabilized.
With this, you can generate a Transcript that you can use along a sr25519 public to generate a provable seed. The seed is extended with personal data to generate a random number. The provable seed can be verified publically and the result of such proof is the extended provable seed that can be used directly to generate a random number. The PR also contains a pseudo-probabilistic model to generate a threshold based on the stake and a sample ratio hyperparameter.
I also included rudimentary positive tests.
Non.exhaustive TODOs:
Practical tips for PR review & merge: