Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSUB-366: Deploy on demand self-hosted runners #867

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

atodorov
Copy link
Collaborator

@atodorov atodorov commented Jan 3, 2023

Description of proposed changes:

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@atodorov atodorov force-pushed the CSUB-366-on-demand-self-hosted branch 2 times, most recently from dbe10f8 to 3f87e8e Compare January 3, 2023 14:09
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

For full LLVM coverage report click here!

@atodorov atodorov force-pushed the CSUB-366-on-demand-self-hosted branch from 3f87e8e to 4e8721a Compare January 3, 2023 14:21
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2023

Codecov Report

Merging #867 (797e8d2) into dev (39fb3ef) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #867   +/-   ##
=======================================
  Coverage   78.14%   78.14%           
=======================================
  Files          68       68           
  Lines       10666    10666           
=======================================
  Hits         8335     8335           
  Misses       2331     2331           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atodorov atodorov force-pushed the CSUB-366-on-demand-self-hosted branch 20 times, most recently from 2e2d331 to f59048d Compare January 5, 2023 13:33
@atodorov
Copy link
Collaborator Author

atodorov commented Jan 5, 2023

For https://github.com/gluwa/creditcoin/actions/runs/3847172342/jobs/6553565221

  1. A new VM has been provisioned - github-runner-3847172342.westus3.cloudapp.azure.com
  2. A new self-hosted runner is registered with GitHub - github-runner-3847172342
  3. The hardware-benchmarks job is executed on the freshly provisioned runner:
Current runner version: '2.300.2'
Runner name: 'github-runner-3847172342'
Runner group name: 'Default'
Machine name: 'github-runner-3847172342'
  1. After job execution is done the self-hosted runner is removed from GitHub (runners are registered as ephemeral and are removed either after 1 job is executed on them or after 24 hrs of inactivity)
  2. The VM github-runner-3847172342.westus3.cloudapp.azure.com is removed in the last job of the workflow.

For comments around workflow security see #872

@atodorov atodorov changed the base branch from testnet to dev January 5, 2023 15:46
@atodorov atodorov force-pushed the CSUB-366-on-demand-self-hosted branch from 0e44aad to 66c2ac9 Compare January 5, 2023 15:46
@atodorov atodorov marked this pull request as ready for review January 5, 2023 15:47
@atodorov atodorov requested a review from CAGS295 January 5, 2023 15:47
CAGS295
CAGS295 previously approved these changes Jan 9, 2023
.github/runner.bicep Outdated Show resolved Hide resolved
CAGS295
CAGS295 previously approved these changes Jan 10, 2023
nathanwhit
nathanwhit previously approved these changes Jan 10, 2023
using passwords for SSH is terrible and I don't want to expose this
functionality as a deployment parameter
@atodorov atodorov dismissed stale reviews from nathanwhit and CAGS295 via 797e8d2 January 10, 2023 09:25
@atodorov atodorov force-pushed the CSUB-366-on-demand-self-hosted branch from 8e5f33f to 797e8d2 Compare January 10, 2023 09:25
@atodorov atodorov enabled auto-merge (rebase) January 10, 2023 09:25
@atodorov atodorov merged commit e9cef1f into dev Jan 11, 2023
@atodorov atodorov deleted the CSUB-366-on-demand-self-hosted branch January 11, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants