Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger Dependabot less frequently #870

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Conversation

atodorov
Copy link
Collaborator

@atodorov atodorov commented Jan 3, 2023

Description of proposed changes:

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@atodorov atodorov requested a review from CAGS295 January 3, 2023 23:11
@atodorov atodorov assigned nathanwhit and unassigned nathanwhit Jan 3, 2023
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

For full LLVM coverage report click here!

@codecov-commenter
Copy link

Codecov Report

Merging #870 (e11a7ab) into dev (fb56e12) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #870   +/-   ##
=======================================
  Coverage   78.07%   78.07%           
=======================================
  Files          67       67           
  Lines       10617    10617           
=======================================
  Hits         8289     8289           
  Misses       2328     2328           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atodorov atodorov enabled auto-merge (rebase) January 4, 2023 10:44
@atodorov atodorov merged commit cd2e16a into dev Jan 5, 2023
@atodorov atodorov deleted the trigger_dependabot_monthly branch January 5, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants