-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CSUB-373] Fix automated devnet runtime upgrade #877
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atodorov
approved these changes
Jan 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
For full LLVM coverage report click here! |
Codecov Report
@@ Coverage Diff @@
## dev #877 +/- ##
=======================================
Coverage 78.14% 78.14%
=======================================
Files 68 68
Lines 10666 10666
=======================================
Hits 8335 8335
Misses 2331 2331 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
CAGS295
approved these changes
Jan 6, 2023
atodorov
pushed a commit
that referenced
this pull request
Jan 12, 2023
atodorov
pushed a commit
that referenced
this pull request
Jan 13, 2023
atodorov
pushed a commit
that referenced
this pull request
Jan 13, 2023
atodorov
pushed a commit
that referenced
this pull request
Jan 17, 2023
atodorov
pushed a commit
that referenced
this pull request
Jan 18, 2023
atodorov
pushed a commit
that referenced
this pull request
Jan 20, 2023
atodorov
pushed a commit
that referenced
this pull request
Jan 31, 2023
atodorov
pushed a commit
that referenced
this pull request
Feb 2, 2023
atodorov
pushed a commit
that referenced
this pull request
Feb 10, 2023
atodorov
pushed a commit
that referenced
this pull request
Feb 10, 2023
atodorov
pushed a commit
that referenced
this pull request
Feb 10, 2023
atodorov
pushed a commit
that referenced
this pull request
Feb 22, 2023
atodorov
pushed a commit
that referenced
this pull request
Apr 3, 2023
atodorov
pushed a commit
that referenced
this pull request
Apr 13, 2023
atodorov
pushed a commit
that referenced
this pull request
Apr 20, 2023
atodorov
pushed a commit
that referenced
this pull request
Apr 21, 2023
atodorov
pushed a commit
that referenced
this pull request
Apr 25, 2023
atodorov
pushed a commit
that referenced
this pull request
Apr 28, 2023
atodorov
pushed a commit
that referenced
this pull request
May 1, 2023
atodorov
pushed a commit
that referenced
this pull request
May 4, 2023
nathanwhit
added a commit
that referenced
this pull request
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes:
The arguments to the extrinsic for scheduling the upgrade changed slightly. Tested locally and confirmed both
the original issue and that this fix works.
Practical tips for PR review & merge: