Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSUB-373] Fix automated devnet runtime upgrade #877

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Conversation

nathanwhit
Copy link
Contributor

Description of proposed changes:
The arguments to the extrinsic for scheduling the upgrade changed slightly. Tested locally and confirmed both
the original issue and that this fix works.

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@nathanwhit nathanwhit marked this pull request as ready for review January 6, 2023 20:34
Copy link
Collaborator

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atodorov atodorov requested a review from CAGS295 January 6, 2023 20:39
@github-actions
Copy link

github-actions bot commented Jan 6, 2023

For full LLVM coverage report click here!

@codecov-commenter
Copy link

Codecov Report

Merging #877 (49cb3e5) into dev (3cb541a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #877   +/-   ##
=======================================
  Coverage   78.14%   78.14%           
=======================================
  Files          68       68           
  Lines       10666    10666           
=======================================
  Hits         8335     8335           
  Misses       2331     2331           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@CAGS295 CAGS295 merged commit ae6e5ac into dev Jan 6, 2023
@CAGS295 CAGS295 deleted the fix-devnet-upgrade branch January 6, 2023 23:20
atodorov pushed a commit that referenced this pull request Feb 2, 2023
atodorov pushed a commit that referenced this pull request Apr 3, 2023
atodorov pushed a commit that referenced this pull request May 1, 2023
atodorov pushed a commit that referenced this pull request May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants