Fix CI

[nathanwhit]

Description of proposed changes:

Practical tips for PR review & merge:

• All GitHub Actions report PASS
• Newly added code/functions have unit tests
  • Coverage tools report all newly added lines as covered
  • The positive scenario is exercised
  • Negative scenarios are exercised, e.g. assert on all possible errors
  • Assert on events triggered if applicable
  • Assert on changes made to storage if applicable
• Modified behavior/functions - try to make sure above test items are covered
• Integration tests are added if applicable/needed

[github-actions]

For full LLVM coverage report click here!

[CAGS295]

If we cargo check --all-features --all-targets for each package, we could simplify CI.

[codecov-commenter]

Codecov Report

Merging #879 (06fe241) into dev (f0fa693) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #879   +/-   ##
=======================================
  Coverage   78.14%   78.14%           
=======================================
  Files          68       68           
  Lines       10666    10666           
=======================================
  Hits         8335     8335           
  Misses       2331     2331           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[nathanwhit]

For the record, it looks like our coverage job broke. We currently rely on the unstable --doctests option of cargo-llvm-cov (that option depends on some nightly flags), which is what broke in CI.

Since AFAIK we don't actually have any doctests, I removed the --doctests flag to fix the coverage CI job. That removal means that if we did have doctests, we now wouldn't see coverage resulting from their execution so we'd underestimate our coverage a bit. It's a pretty negligible impact even if we did use doctests, imo.