New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert hard-coded version strings to regex for MegaLinter #55

Merged

atodorov merged 1 commit into dev from fix-megalinter

Nov 8, 2023

Contributor

atodorov commented Nov 8, 2023

I thought I had fixed this before!

Description of proposed changes

Practical tips for PR review & merge:

All GitHub Actions report PASS
Newly added code/functions have unit tests
- Coverage tools report all newly added lines as covered
- The positive scenario is exercised
- Negative scenarios are exercised, e.g. assert on all possible errors
- Assert on events triggered if applicable
- Assert on changes made to storage if applicable
Modified behavior/functions - try to make sure above test items are covered
Integration tests are added if applicable/needed


          Convert hard-coded version strings to regex for MegaLinter

61286a7

I thought I had fixed this before!

atodorov merged commit 80f52ec into dev

9 of 14 checks passed

atodorov deleted the fix-megalinter branch

November 8, 2023 09:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment