Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSUB-897: Rename from creditcoin-next to creditcoin3 #57

Merged
merged 3 commits into from
Nov 9, 2023
Merged

CSUB-897: Rename from creditcoin-next to creditcoin3 #57

merged 3 commits into from
Nov 9, 2023

Conversation

atodorov
Copy link
Contributor

@atodorov atodorov commented Nov 9, 2023

Description of proposed changes

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@atodorov atodorov force-pushed the csub-897-rename-to-creditcoin3 branch from 103c4cc to fbf99c4 Compare November 9, 2023 09:14
@atodorov
Copy link
Contributor Author

atodorov commented Nov 9, 2023 •
edited
Loading

  • CI / integration-test-check-extrinsics - fails because of the name change. I will push a new git tag once this gets merged and the Docker repository renamed to unblock future test executions.
  • Check runtime changes / danger-will-brick-the-blockchain - false positive. Fails b/c the diff includes SLOT_DURATION however the actual value has not been updated!

@atodorov atodorov merged commit 89aa9db into dev Nov 9, 2023
13 of 15 checks passed
@atodorov atodorov deleted the csub-897-rename-to-creditcoin3 branch November 9, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharyfrederick zacharyfrederick zacharyfrederick approved these changes

@pLabarta pLabarta pLabarta approved these changes

@nathanwhit nathanwhit Awaiting requested review from nathanwhit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atodorov @zacharyfrederick @pLabarta