Update webapp dependencies #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new include gemmi/polyheur.hpp to privateer-bind.cpp to enhance polyheuristic functionality. Also fixed an issue in privateer-json.h where the sajson library was being included from gemmi package that may lead to 'multiple definition of enum' errors. The correct include path is now used.
In this commit, the arrangement of the files in CMakeLists.txt has been significantly simplified. In gemmi/CMakeLists.txt, the static library gemmi_cpp is changed to a regular library and globbing is used to include header files instead of listing them individually. Similarly, in the main CMakeLists.txt, unnecessary code blocks for testing mode or ccp4srs have been removed and some modifications have been done on setting flags and file paths.
Changed the method of fetching Clipper's source from "bzr checkout" to downloading and extracting a tarball. For Gemmi, updated the version being fetched from 0.5.8 to 0.6.5. These changes reflect more updated and efficient ways of acquiring these sources.
This commit adds the 'detect-browser' package and uses it within the fetchPDBFile function. This change handles a unique situation where Firefox fails to work with CIF files, so for Firefox users, it fetches PDB files instead.
String references were harmonized to single quotation marks (' ') for standardization purposes. This change particularly affects the import statement from 'detect-browser' and the browser name check condition for 'firefox'.
The return types for both fetchPDB and fetchPDBFile methods have been updated. These functions now return a tuple including the file content and its filename extension instead of just the text. This change provides more detailed information about the fetched files.
A 'detect-browser' package has been imported to check the kind of browser the user is employing. Introduced handling for CIF files which are currently unsupported on Firefox. New logic is now in place to handle the behavior for Firefox users to guide them to use an alternate browser.
The function 'read_molecule' in privateer-bind.cpp has been refactored for simplicity and efficiency. It now uses a direct file read operation instead of converting the file content to a character array first. The function also now checks if the molecule's spacegroup is null and performs initialization if required.
Modified the browser check condition for Firefox to include both 'cif' and 'mmcif' file extensions. This is to prevent potential issues since these types of files are currently unsupported on the Firefox browser.
Updated source for checking out libccp4 and mmdb2 packages, replacing lightweight bzr checkout with tarball downloads to improve reliability and performance. Refactored CMakeLists.txt to better handle zlib inclusion, providing a fallback to a third-party source when not found in the system.
The method of including the sajson.h header file has been changed from directly calling it from gemmi to calling it from a third-party location.
This update includes changes in webapp/package-lock.json that reflect the updated puppeteer version and related dependencies. It
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Testing
This is a large pull request which changes a lot of the backend, the following must be tested on Chrome and Firefox at the minimum but also Safari preferably.