Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch CIF files from the PDB preferentially #99

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Conversation

Dialpuri
Copy link
Collaborator

@Dialpuri Dialpuri commented Jun 5, 2024

Description

This PR adds the functionality to first search for a CIF file in the PDB, then if one is not found, try to find a PDB. This should allow for larger, CIF-only structures to be validated.

The update modifies all external anchor tags to include "rel=noreferrer". This change mitigates potential security risks related to the opening of external sites, such as reverse tabnabbing, and maintains the integrity and safety of the web application.
Introduced a fallback function, fetchPDBFile, that attempts to fetch a PDB file in case fetching the CIF file fails. This function catches networking errors and provides clearer logging to facilitate troubleshooting. It also improves the error handling for existing fetchPDB function.
@Dialpuri Dialpuri requested a review from lcs551 June 5, 2024 10:19
@Dialpuri Dialpuri added the enhancement New feature or request label Jun 5, 2024
@Dialpuri Dialpuri added this to In progress in Privateer Webapp via automation Jun 5, 2024
@Dialpuri Dialpuri merged commit 1c746a2 into webapp Jun 5, 2024
2 checks passed
Privateer Webapp automation moved this from In progress to Done Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants