sketch of new type-annotation-based interface #137

glyph · 2022-03-16T01:27:30Z

Fixes #145

obviously needs tests and perhaps some more thought (in particular… how would feedback state-changes work here?) but I think this might be cleaner than the methodical machine

codecov-commenter · 2022-06-16T00:54:52Z

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2da0af1) 91.82% compared to head (9466e8f) 94.18%.

Files	Patch %	Lines
automat/_typical.py	99.19%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            trunk     #137      +/-   ##
==========================================
+ Coverage   91.82%   94.18%   +2.36%     
==========================================
  Files          11       13       +2     
  Lines        1260     1806     +546     
==========================================
+ Hits         1157     1701     +544     
- Misses        103      105       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This commit was sponsored by zts, James C Abel, Jason Walker, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

This commit was sponsored by Derek Veit, Holly B, Al Sweigart, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

This commit was sponsored by Sean Reifschneider, Steven S., Jason Mills, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

This commit was sponsored by rockstar, Devin Prater, Derek Veit, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

This commit was sponsored by Jason Walker, Devin Prater, Moshez, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

… when no factory is implicated This commit was sponsored by tgs, Thomas Ballinger, Mahmoud Hashemi, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

This commit was sponsored by AJ Collins, rockstar, Derek Veit, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

This commit was sponsored by Christopher Neugebauer, Jason Mills, Devin Prater, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

This commit was sponsored by Jason Walker, Devin Prater, Jason Mills, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

This commit was sponsored by hacklschorsch, rockstar, Jim W, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

This commit was sponsored by Matt Campbell, rockstar, Sergio Bost, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

This commit was sponsored by Matt Campbell, Steven S., Devin Prater, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

This commit was sponsored by Matt Campbell, Hynek, hacklschorsch, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

This commit was sponsored by Jason Mills, Derek Veit, Devin Prater, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

This commit was sponsored by rockstar, Derek Veit, Sergio Bost, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

This commit was sponsored by Devin Prater, Jason Mills, jhulten, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

This commit was sponsored by Devin Prater, Jason Mills, Matt Campbell, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

This commit was sponsored by Matt Campbell, Steven S., hacklschorsch, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

This commit was sponsored by Jason Mills, Steven S., Devin Prater, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

This commit was sponsored by Sergio Bost, Jason Mills, Devin Prater, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

This commit was sponsored by Sergio Bost, hacklschorsch, Jason Mills, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

This commit was sponsored by Jason Mills, hacklschorsch, Matt Campbell, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

This commit was sponsored by hacklschorsch, Matt Campbell, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

This commit was sponsored by Matt Campbell, hacklschorsch, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

This commit was sponsored by hacklschorsch, Matt Campbell, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

glyph · 2024-08-01T06:23:20Z

Stuff to do before landing:

visualization cleanups: outputs need much shorter, pithier names that look good in a visualization (inputs and states are OK)
serialization: I need a way to serialize & deserialize the current state of a machine, for database-resident state machines.
documentation: all the documentation needs to be rewritten to use TypeMachineBuilder
internal naming: _typified is a bit of a silly name, renaming to something like _typed would be better.
typing: possibly TypeMachine needs to be public so that people who want to call .asDigraph (or whatever the tracing or serialization APIs are) can still annotate their return types

This commit was sponsored by hacklschorsch, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

This commit was sponsored by Derek Veit, Devin Prater, James C Abel, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

…-door as initial example This commit was sponsored by jhulten, Al Sweigart, Sergio Bost, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

glyph added 24 commits March 15, 2022 18:26

sketch of new type-annotation-based interface

72e3af3

better handling of initial state

9a17043

alternate implementation strategy

fbd8f7f

explain aspiration for ParamSpec

ec2eab1

expose it

da680e5

blacken examples

6091ea4

clean up first impl, add some notes

7fd39d2

literal translation of example

4959aea

mark as typed

2a41fc0

Merge remote-tracking branch 'origin/master' into typical

d712af4

the future is now

ea70a93

magically propagate required attributes

6f45213

refactoring

c2a6528

change lifecycle so that we are instantiating stuff with the right args

b07cbf8

oh hey we can totally make .build typecheck now that ParamSpec works

1ad5e58

correct implementation of persist flag

8b06bac

CI fixes, version compat

7eac098

Merge remote-tracking branch 'origin/trunk' into typical

7370242

wip

70e23c2

fix

d622890

let me see the error codes for more precise type:ignores

2d0a904

bug workarounds, rip out examples

94fbe17

temporary home for examples

bc90112

fix up some semantics, do DI for public & private interfaces into states

e7b0dfd

glyph mentioned this pull request Jun 13, 2022

automat2: type-hints based API with a separate class per state #145

Open

4 tasks

glyph added 4 commits June 15, 2022 17:25

that lives in a different example now

2c26e4b

Merge remote-tracking branch 'origin/trunk' into typical

0d4772e

Merge remote-tracking branch 'origin/trunk' into typical

deb8b58

correct syntax

4cc9b79

glyph added 26 commits July 30, 2024 12:01

debugging aid: warn users when they forget to fully declare a transition

71be582

This commit was sponsored by zts, James C Abel, Jason Walker, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

test data-state to data-state transition

a3b1f9e

This commit was sponsored by Derek Veit, Holly B, Al Sweigart, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

stricter / more correct FactoryParams match verification

0487f15

This commit was sponsored by Sean Reifschneider, Steven S., Jason Mills, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

inverse argument check

b5a7966

This commit was sponsored by rockstar, Devin Prater, Derek Veit, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

warn on unused ignores

bd1c99b

This commit was sponsored by Jason Walker, Devin Prater, Moshez, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

same semantics but different implication; let's not use FactoryParams…

436bd5c

… when no factory is implicated This commit was sponsored by tgs, Thomas Ballinger, Mahmoud Hashemi, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

add defaults to illustrate signature-match problem

6669e04

This commit was sponsored by AJ Collins, rockstar, Derek Veit, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

reverse method chain invocation order to deal with ParamSpec variance

782abe2

This commit was sponsored by Christopher Neugebauer, Jason Mills, Devin Prater, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

reverse to/upon ordering in tests, which now fail

c92b52e

This commit was sponsored by Jason Walker, Devin Prater, Jason Mills, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

same update in examples

38dfc7d

This commit was sponsored by hacklschorsch, rockstar, Jim W, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

add back 'dataless()' in the form of 'nodata'

f88a985

This commit was sponsored by Matt Campbell, rockstar, Sergio Bost, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

old Python versions

0986731

This commit was sponsored by Matt Campbell, Steven S., Devin Prater, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

oops now mypy is configured to warn on unused ignores

dc3ec98

This commit was sponsored by Matt Campbell, Hynek, hacklschorsch, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

explicitly test reentrancy

6c5d88e

This commit was sponsored by Jason Mills, Derek Veit, Devin Prater, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

remove some dead code

fac3971

This commit was sponsored by rockstar, Derek Veit, Sergio Bost, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

test for type machine discovery

a5ea7b0

This commit was sponsored by Devin Prater, Jason Mills, jhulten, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

visualization test cases

2388da9

This commit was sponsored by Devin Prater, Jason Mills, Matt Campbell, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

black

03173df

This commit was sponsored by Matt Campbell, Steven S., hacklschorsch, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

minor coverage tweaks

b24f303

This commit was sponsored by Jason Mills, Steven S., Devin Prater, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

these are tests for code that shouldn't be run, so annotate them as such

c8f2df9

This commit was sponsored by Sergio Bost, Jason Mills, Devin Prater, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

NoTransition test

77ffcb3

This commit was sponsored by Sergio Bost, hacklschorsch, Jason Mills, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

test coverage for unhandledTransition

5b7175c

This commit was sponsored by Jason Mills, hacklschorsch, Matt Campbell, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

add future-annotations import to stringify some stuff

948cae9

This commit was sponsored by hacklschorsch, Matt Campbell, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

Sequence[Output]

de9156e

This commit was sponsored by Matt Campbell, hacklschorsch, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

eliminate code that is possibly vestigial from python2

1bb0295

This commit was sponsored by hacklschorsch, Matt Campbell, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

black

b818a34

This commit was sponsored by hacklschorsch, Matt Campbell, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

glyph added 3 commits August 1, 2024 15:14

consistent state names

113af0b

This commit was sponsored by hacklschorsch, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

fix method ordering

c5d9a19

This commit was sponsored by Derek Veit, Devin Prater, James C Abel, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

start switching over from coffee-machine as initial example to garage…

826f126

…-door as initial example This commit was sponsored by jhulten, Al Sweigart, Sergio Bost, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sketch of new type-annotation-based interface #137

sketch of new type-annotation-based interface #137

glyph commented Mar 16, 2022 •

edited

Loading

codecov-commenter commented Jun 16, 2022 •

edited

Loading

glyph commented Aug 1, 2024

sketch of new type-annotation-based interface #137

Are you sure you want to change the base?

sketch of new type-annotation-based interface #137

Conversation

glyph commented Mar 16, 2022 • edited Loading

codecov-commenter commented Jun 16, 2022 • edited Loading

Codecov Report

glyph commented Aug 1, 2024

glyph commented Mar 16, 2022 •

edited

Loading

codecov-commenter commented Jun 16, 2022 •

edited

Loading