-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
automat: the next generation #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## trunk #137 +/- ##
==========================================
+ Coverage 91.82% 94.18% +2.36%
==========================================
Files 11 13 +2
Lines 1260 1806 +546
==========================================
+ Hits 1157 1701 +544
- Misses 103 105 +2 ☔ View full report in Codecov by Sentry. |
This commit was sponsored by Matt Campbell, hacklschorsch, Jason Walker, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
…'postponed' check This commit was sponsored by Steven S., Devin Prater, Jason Walker, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
This commit was sponsored by Jason Walker, Devin Prater, Jason Mills, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
This commit was sponsored by Jason Mills, hacklschorsch, Derek Veit, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
This commit was sponsored by Devin Prater, Sergio Bost, Steven S., and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
This commit was sponsored by Derek Veit, Jason Mills, Devin Prater, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
This commit was sponsored by hacklschorsch, Matt Campbell, Steven S., and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
This commit was sponsored by hacklschorsch, Matt Campbell, Devin Prater, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
This commit was sponsored by Matt Campbell, Devin Prater, hacklschorsch, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
This commit was sponsored by Matt Campbell, hacklschorsch, Devin Prater, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
This commit was sponsored by Matt Campbell, hacklschorsch, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
This commit was sponsored by Matt Campbell, hacklschorsch, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
This commit was sponsored by Matt Campbell, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
This commit was sponsored by Matt Campbell, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
This commit was sponsored by Steven S., Jason Walker, Thomas Ballinger, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
This commit was sponsored by Jason Mills, AJ Collins, Steven S., and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
This commit was sponsored by hacklschorsch, Steven S., Matt Campbell, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
This commit was sponsored by Jason Mills, Mahmoud Hashemi, Samuel Coleman, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
This commit was sponsored by Holly B, jhulten, Al Sweigart, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
This commit was sponsored by James C Abel, Jason Walker, hacklschorsch, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
This commit was sponsored by hacklschorsch, Matt Campbell, Sergio Bost, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
This commit was sponsored by Jason Walker, Christopher Neugebauer, tgs, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
This commit was sponsored by Jason Walker, Derek Veit, Devin Prater, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
This commit was sponsored by Matt Campbell, hacklschorsch, Jason Mills, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
This commit was sponsored by rockstar, Sergio Bost, Sean Reifschneider, and my other patrons. If you want to join them, you can support my work at https://glyph.im/patrons/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145
obviously needs tests and perhaps some more thought (in particular… how would feedback state-changes work here?) but I think this might be cleaner than the methodical machine
Stuff to do before landing:
.to
/.upon
ordering for better type errors_typified
is a bit of a silly name, renaming to something like_typed
would be better.TypeMachine
needs to be public so that people who want to call.asDigraph
(or whatever the tracing or serialization APIs are) can still annotate their return typesbuilder.state
,state.upon
,upon.to
etc) must raise an exception if.build
has already been called