Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for positional only arguments #111

Closed
wants to merge 1 commit into from

Conversation

eclipseo
Copy link
Contributor

PEP 570 adds "positional only" arguments to Python, which changes the
code object constructor. This adds support for Python 3.8.

Signed-off-by: Robert-André Mauchin zebob.m@gmail.com

Tested in Fedora Rawhide with Python 3.8a4.

PEP 570 adds "positional only" arguments to Python, which changes the
code object constructor. This adds support for Python 3.8.

Signed-off-by: Robert-André Mauchin <zebob.m@gmail.com>
@glyph
Copy link
Owner

glyph commented Aug 4, 2019

@eclipseo thanks for the contribution! Any chance you could add some CI configuration for this so we can land it?

Copy link
Owner

@glyph glyph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this had a little bit of test coverage I'd love to land it.

markrwilliams added a commit to markrwilliams/automat that referenced this pull request Oct 19, 2019
This will fail until glyph#111 is merged.
@markrwilliams
Copy link
Collaborator

Closing so I can rebase your commit on top of #119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants