Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for intermediate certificates loading #19

Closed
evilaliv3 opened this issue Mar 22, 2017 · 2 comments
Closed

Support for intermediate certificates loading #19

evilaliv3 opened this issue Mar 22, 2017 · 2 comments

Comments

@evilaliv3
Copy link

Current implementation does not allow to load an intermediate certificate.

This requirement is particular important in order to guarantee that the certificate chain offered by the SSL server is complete and trusted by the client.

As far that i know given the current implementation of twisted certificate validators this could not be implemented just using the function PrivateCertificate.fromCertificateAndKeyPair that is currently used but would require to have a directly a call to pyopenssl API add_extra_chain_cert(intermediate) to attach the intermediate certificates to the context.

@evilaliv3
Copy link
Author

probably an up to date solution to add this would be to use OpenSSLCertificateOptions() in place of PrivateCertificate.fromCertificateAndKeyPair()

@glyph
Copy link
Owner

glyph commented Mar 23, 2017

This report is inaccurate. Put your intermediates into the same pem file as your certificate and key, and txsni will figure out which one is the certificate that matches the private key, and uses the rest as intermediates.

You can see where it passes the intermediates to CertificateOptions here:

extraCertChain=openSSLChain)

Thanks for using TxSNI, though!

@glyph glyph closed this as completed Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants