-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't cache certificates #22
Conversation
This makes trial's report more readable.
This caching prevents SNIMap from using regenerated certificate files.
|
This allows SNIMap to always serve the latest certificates from the file system.
b153614
to
d04ff74
Compare
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
+ Coverage 87.77% 93.76% +5.98%
==========================================
Files 7 6 -1
Lines 360 385 +25
Branches 27 28 +1
==========================================
+ Hits 316 361 +45
+ Misses 33 14 -19
+ Partials 11 10 -1
Continue to review full report at Codecov.
|
We don't need pyenv because we can get a new enough PyPy (5.8.0) for cryptography by specifying "trusty" in .travis.yml We don't need OpenSSL 1.0.2 because cryptography ships manylinux wheels statically linked against OpenSSL 1.1
c41d7ee
to
7a14957
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Love the test coverage. Thanks!
Caching prevents the
txsni:
endpoint from loading regenerated certificates.What might regenerate certificates? txacme or certbot!