Test ALPN and NPN separately. #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenSSL does not support NPN with TLS 1.3 (openssl/openssl#3665) so don't attempt NPN if it's likely TLS 1.3 will be used.
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
=========================================
+ Coverage 93.87% 95.5% +1.62%
=========================================
Files 6 6
Lines 392 400 +8
Branches 28 28
=========================================
+ Hits 368 382 +14
+ Misses 14 10 -4
+ Partials 10 8 -2
Continue to review full report at Codecov.
|
glyph
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSL does not support NPN with TLS
1.3 (openssl/openssl#3665) so don't attempt
NPN if it's likely TLS 1.3 will be used.
Unblocks #23.