Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-public UCDParser.defaultParser #3

Closed
mbtaylor opened this issue Jul 7, 2021 · 1 comment
Closed

non-public UCDParser.defaultParser #3

mbtaylor opened this issue Jul 7, 2021 · 1 comment
Assignees
Projects
Milestone

Comments

@mbtaylor
Copy link

mbtaylor commented Jul 7, 2021

@gmantele, is there a good reason that the UCDParser.defaultParser instance is declared with scope protected? It makes it complicated to work with custom UCDParser instances, e.g. to get a copy of the default word list (though not impossible, you can get access to the member by subclassing UCDParser). If there's not a good reason, could it be promoted to public?

@gmantele
Copy link
Owner

gmantele commented Jul 7, 2021

You're right. I assume that at that time I considered it as useless for users that would generally like to create their own parser (and then use the protected static attribute) or use the default parser through UCDParser.parseUCD(String). Besides, when protected, there are much less risk that someone alter the "official" list of IVOA words and so get a strange result when parsing a UCD. But the risk is quite low and people doing are generally pretty aware of that risk.

So, I just changed the visibility of this default parser. It is now public.

Currently, this is only available in the branch ucidy-1.2. I created a Pre-Release where you can get the (runnable) JAR for this branch: https://github.com/gmantele/ucidy/releases/tag/ucidy-1.2 . This pre-release also includes the new list of UCD1+ (UCDlist-1.4).

@gmantele gmantele self-assigned this Jul 7, 2021
@gmantele gmantele added this to the Ucidy-1.2 milestone Jul 15, 2021
@gmantele gmantele added this to To do in Ucidy-1.2 Jul 15, 2021
@gmantele gmantele moved this from To do to Done in Ucidy-1.2 Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants