You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@gmantele, is there a good reason that the UCDParser.defaultParser instance is declared with scope protected? It makes it complicated to work with custom UCDParser instances, e.g. to get a copy of the default word list (though not impossible, you can get access to the member by subclassing UCDParser). If there's not a good reason, could it be promoted to public?
The text was updated successfully, but these errors were encountered:
You're right. I assume that at that time I considered it as useless for users that would generally like to create their own parser (and then use the protected static attribute) or use the default parser through UCDParser.parseUCD(String). Besides, when protected, there are much less risk that someone alter the "official" list of IVOA words and so get a strange result when parsing a UCD. But the risk is quite low and people doing are generally pretty aware of that risk.
So, I just changed the visibility of this default parser. It is now public.
Currently, this is only available in the branch ucidy-1.2. I created a Pre-Release where you can get the (runnable) JAR for this branch: https://github.com/gmantele/ucidy/releases/tag/ucidy-1.2 . This pre-release also includes the new list of UCD1+ (UCDlist-1.4).
@gmantele, is there a good reason that the
UCDParser.defaultParser
instance is declared with scopeprotected
? It makes it complicated to work with customUCDParser
instances, e.g. to get a copy of the default word list (though not impossible, you can get access to the member by subclassingUCDParser
). If there's not a good reason, could it be promoted topublic
?The text was updated successfully, but these errors were encountered: