New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build with GCC8 #142

Closed

pkubaj wants to merge 4 commits into gmarcais:master from pkubaj:patch-1

Contributor

pkubaj commented May 13, 2019 •

edited

Replace couple of exceptions from using value to references:

sub_commands/count_main.cc:333:28: error: catching polymorphic type 'class MergeError' by value [-Werror=catch-value=]
         } catch(MergeError e) {

pkubaj added 4 commits

May 13, 2019 09:57


          Fix build with GCC8

ed52654


          Fix build with GCC 8

455a9d5


          Fix build with GCC 8

e694e87


          Fix build with GCC 8

158942a

Owner

gmarcais commented May 15, 2019

This was merged into the develop branch. It will appear in master and version 2.3.0 shortly. Thanks for the patches.

gmarcais closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment