Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #374 shellescape problem #380

Closed
wants to merge 2 commits into from
Closed

Fix #374 shellescape problem #380

wants to merge 2 commits into from

Conversation

Shougo
Copy link
Contributor

@Shougo Shougo commented Feb 6, 2014

I fixed shellescape problem and tests.
I tested it, but it is not under Windows. Can you test this fix before including?

@gmarik gmarik mentioned this pull request Feb 7, 2014
@starcraftman
Copy link
Contributor

Hi @Shougo, I have Windows so I can test this. I'm not super familiar with GitHub's work flow. Is there an easy way I can get a simple patch file to apply with git to vundle? Do I need to be a collaborator?

I'll mention @gmarik in case he wants to answer.

@gmarik
Copy link
Contributor

gmarik commented Feb 8, 2014

@starcraftman just add .patch to the url

Thanks for checking it out!

@starcraftman
Copy link
Contributor

@gmarik Thanks. That's pretty easy. I'll try it after lunch.

@starcraftman
Copy link
Contributor

@Shougo @gmarik

I just tested this on Windows 7 64bit with Vim. Works as expected. Without the patch and with shellslash set I get an error. With the patch applied to the latest vundle it works as expected.

Only warning I got is that there is a trailing whitespace on line 96 of the patch, otherwise works as advertised.

@gmarik
Copy link
Contributor

gmarik commented Feb 9, 2014

Tested on OSX no issues found…
Merged in 4472ffa
Thank you!

@gmarik gmarik closed this Feb 9, 2014
@Shougo
Copy link
Contributor Author

Shougo commented Feb 10, 2014

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants