Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper handling for the case when ~/.vim is under source control #116

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

maljub01
Copy link

When the user's ".vim" folder is part of a git repo, using git clone and git add (as the plugin does) creates a "semi-submodule" which doesn't work properly. This commit makes vundle check first if this is the case, and if so properly adds the bundles as git submodules.

…es as proper submodules (using relative paths)
@gmarik
Copy link
Contributor

gmarik commented Nov 24, 2011

Thanks for the pull request!

Few notes:

  1. everyone keeps ~/.vim under control (or should be)
  2. not everyone keeps ~/.bundle under source control tho
  3. I assume you do keep ~/.bundle scm-ed that's why you had this "semi-submodule" issue

Not merging your commit in yet, but it will be used to add submodule support to Vundle soon!

Let me know what you think!
Thanks again!

@maljub01
Copy link
Author

You're right, that's exactly the case. I am keeping ~/.bundle under scm mainly because this way when I clone my dotfiles repo I don't have to clone vundle as well. And I also get the added benefit of having all my other bundles already installed too.

@maljub01
Copy link
Author

The last few commits extend submodule support to updating & deleting bundles. It works well on Linux. I'm pretty sure it needs some modifications to work properly on Windows though.

@gmarik
Copy link
Contributor

gmarik commented Nov 29, 2011

That's cool maljub01!
I'll take a look!

@silasb
Copy link

silasb commented May 5, 2012

I think I'm interested in this.

What I'm looking for is some way to install my bundles in a specific location. I think $HOME/.vim/bundles would be good, so I could easily ignore that in my SCM.

@maljub01 maljub01 mentioned this pull request Oct 21, 2013
@MarcWeber
Copy link

#145 (related to)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants