Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove WORD_PARAMS and SUGGEST_PARAMS. #7

Closed
kasteph opened this issue Sep 9, 2018 · 1 comment
Closed

Remove WORD_PARAMS and SUGGEST_PARAMS. #7

kasteph opened this issue Sep 9, 2018 · 1 comment

Comments

@kasteph
Copy link
Contributor

kasteph commented Sep 9, 2018

The list of parameters in WORD_PARAMS and SUGGEST_PARAMS are unnecessary since the Datamuse API ignores parameters it does not recognize anyway. Therefore, the argument check Datamuse._validate_args is superfluous. Thoughts, @gmarmstrong ?
@kasteph
Copy link
Contributor Author

kasteph commented Sep 20, 2018

PR #8 removes the SUGGEST_PARAMS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kasteph