New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional arguments to `suggest` method. #8

Merged

gmarmstrong merged 1 commit into gmarmstrong:master from kasteph:improvement/suggest

Sep 20, 2019

Contributor

kasteph commented Sep 18, 2018 •

edited

Loading

Instead of having a list of possible keyword arguments to suggest, be more prescriptive and have them as named arguments in the function signature.

Changelog:

Remove SUGGEST_PARAMS in favor of using named arguments in function signature.
Add a happy path test for the suggestion endpoint.
Add docstring documentation for the suggestion method.
The implementation does not change anything in the interface ⭐️


          Add max_results and vocabulary as optional arguments to the suggest m…

ee2d868

…ethod instead of as keyword arguments.

kasteph mentioned this pull request

Remove WORD_PARAMS and SUGGEST_PARAMS. #7

Closed

gmarmstrong merged commit ee2d868 into gmarmstrong:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment