Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock the datamuse API and use fixtures for responses. #6

Merged
merged 2 commits into from Sep 5, 2018

Conversation

kasteph
Copy link
Contributor

@kasteph kasteph commented Aug 26, 2018

Mock the datamuse API for tests and do a bit of restructuring the project according to The Hitchhiker's Guide to Python.

The branch is currently failing since I used f-strings (which is only supported in 3.6+), while the Travis CI is using Python 3.5.

@gmarmstrong
Copy link
Owner

Travis got confused by the requirements files. Is travis.yml correctly listing which ones need to be loaded?

@kasteph
Copy link
Contributor Author

kasteph commented Sep 5, 2018

Thanks for pointing that out. I forgot to specify the correct requirements file. Build is passing now :)

@gmarmstrong gmarmstrong merged commit 174d634 into gmarmstrong:master Sep 5, 2018
@kasteph kasteph deleted the improvement/mock-tests branch September 5, 2018 13:00
@gmarmstrong
Copy link
Owner

gmarmstrong commented Sep 5, 2018

Thanks! I'll update the changelog and PyPI shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants