Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support msgctxt for keyword parameter #56

Closed
arm1n opened this issue Jul 20, 2016 · 3 comments
Closed

Support msgctxt for keyword parameter #56

arm1n opened this issue Jul 20, 2016 · 3 comments

Comments

@arm1n
Copy link

arm1n commented Jul 20, 2016

It seems that message contexts are currently not supported in the way they're specified with common xgettext format like so:

--keyword=pgettext:1c,2
--keyword=npgettext:1c,2,3

Cannot speak for other parsers, but gettext-handlebars actually has support for msgctxt. Are there any plans to support this in the near future? Thanks for any feedback!

@smhg
Copy link
Collaborator

smhg commented Jul 20, 2016

Thanks for the reminder. This should definitely be supported.
It is true that the Handlebars parser covers contexts. I didn't look into others, but this won't break anything.
Would you be able to send a PR? I haven't used contexts as far as I remember so you might be better placed to add this.

@smhg
Copy link
Collaborator

smhg commented Sep 15, 2016

As a reminder: parser results that contain contexts are now processed thanks to @x-cray.
Next step would be to retrieve context information from the keyword spec.

smhg pushed a commit that referenced this issue Oct 8, 2016
@smhg smhg closed this as completed in 12915f7 Oct 8, 2016
@dschissler
Copy link

I'll have to look into this for the Volt parser. It will probably be a while though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants