Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist throttle/debounce arguments #1

Merged
merged 4 commits into from
Apr 7, 2016
Merged

Conversation

gmcquistin
Copy link
Owner

Resolves #2.

I have copied throttle and debounce from the Lodash library and added a line which clones the arguments, so the debounced function will receive a clone of the original arguments. In this way, even if the original caller modifies the arguments after the fact, we will still have a copy.

@codecov-io
Copy link

Current coverage is 87.27%

Merging #1 into master will decrease coverage by -12.73% as of c58767c

@@            master      #1   diff @@
======================================
  Files            5       7     +2
  Stmts           30     110    +80
  Branches         5      23    +18
  Methods          0       0       
======================================
+ Hit             30      96    +66
  Partial          0       0       
- Missed           0      14    +14

Review entire Coverage Diff as of c58767c

Powered by Codecov. Updated on successful CI builds.

@gmcquistin gmcquistin changed the title Persist React events Persist throttle/debounce arguments Apr 7, 2016
@liddellj
Copy link

liddellj commented Apr 7, 2016

LGTM 👍

@gmcquistin gmcquistin merged commit 08d3e16 into master Apr 7, 2016
@gmcquistin gmcquistin deleted the persist-react-events branch April 7, 2016 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants