Skip to content

Commit

Permalink
Node4 (#15)
Browse files Browse the repository at this point in the history
* Added support for node 4

* Strict 4.0 version of node for testing

* Added change log
  • Loading branch information
gmetzker committed Jan 16, 2017
1 parent c7a7582 commit 00dd20b
Show file tree
Hide file tree
Showing 6 changed files with 57 additions and 9 deletions.
7 changes: 6 additions & 1 deletion .eslintrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,14 @@ plugins:

env:
mocha: true

node: true

rules:
padded-blocks: off
no-trailing-spaces: [error, skipBlankLines: true]
comma-dangle: [error, never]

# Doesn't work in node v4
strict: off
prefer-rest-params: off
prefer-spread: off
2 changes: 2 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
language: node_js

node_js:
- "4.0"
- "6"
- "7"

# For code coverage:
after_success:
Expand Down
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# 1.0.0 (2017-01-15)

## Features
* Basic support to assign the Lambda `DeadLetterConfig` using after serverless Cloudformation stack is deployed. [Amazon Docs](http://docs.aws.amazon.com/lambda/latest/dg/dlq.html)
* Plugin makes a call to the [Lambda Api](http://docs.aws.amazon.com/lambda/latest/dg/API_UpdateFunctionConfiguration.html)
`UpdateFunctionConfiguration`
* Using a pre-existing SQS Queue or SNS Topic as a dead letter target.
* Using an SNS Queue or SNS Topic created in the resources section.
* Remove a previously existing dead letter `targetArn` by specifying a blank `targetArn`
37 changes: 33 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,16 +1,23 @@
{
"name": "hli-serverless-plugin-lambda-dead-letter",
"name": "serverless-plugin-lambda-dead-letter",
"version": "1.0.0",
"description": "Plugin for serverless to set the DeadLetterConfig for lambda functions",
"description": "serverless plugin that can configure a lambda with a dead letter queue or topic",
"main": "src/index.js",
"scripts": {
"test": "grunt standards && ./node_modules/.bin/istanbul cover ./node_modules/.bin/_mocha -- -R spec 'tests/**/*.test.js'"
},
"engines": {
"node": ">=4.0"
},
"author": "Gary Metzker",
"license": "MIT",
"homepage": "https://github.com/gmetzker/serverless-plugin-lambda-dead-letter#readme",
"repository": {
"type": "git",
"url": "https://github.hli.io/HLI/serverless-plugin-lambda-dead-letter.gite"
"url": "https://github.com/gmetzker/serverless-plugin-lambda-dead-letter.git"
},
"bugs": {
"url": "https://github.com/gmetzker/serverless-plugin-lambda-dead-letter/issues"
},
"keywords": [
"serverless plugin dead letter",
Expand All @@ -33,5 +40,27 @@
"istanbul": "^0.4.5",
"mocha": "^3.2.0",
"sinon": "^1.17.7"
}
},
"files": [
"src"
],
"keywords": [
"serverless",
"serverless framework",
"serverless plugin",
"serverless plugins",
"lambda",
"aws",
"aws lambda",
"amazon",
"amazon web services",
"dead letter",
"dead letter config",
"DeadLetterConfig",
"sqs queue",
"queue",
"DLQ",
"sns topic",
"topic"
]
}
1 change: 1 addition & 0 deletions src/index.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
'use strict';

const BbPromise = require('bluebird');

Expand Down
10 changes: 6 additions & 4 deletions tests/index.test.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@

'use strict';

const expect = require('expect.js');
const Plugin = require('../src/index.js');
Expand Down Expand Up @@ -50,17 +50,19 @@ describe('serverless-plugin-lambda-dead-letter', () => {

function createMockRequest(requestStub) {

return (...reqArgs) =>
return () => {

new BbPromise((resolve, reject) => {
const result = requestStub(...reqArgs);
const reqArgs = Array.prototype.slice.call(arguments);
return new BbPromise((resolve, reject) => {
const result = requestStub.apply(undefined, reqArgs);
if (result !== null) {
resolve(result);
return;
}
reject(new Error(`Call to request() with unexpected arguments: ${JSON.stringify(reqArgs)}`));

});
};


}
Expand Down

0 comments on commit 00dd20b

Please sign in to comment.