Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

Target 1.16.3 for 1_16_R2; bump mcVersion for 1_16_R3 and 1_20_R3 #113

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

datatags
Copy link
Contributor

@datatags datatags commented Feb 3, 2024

Info

This PR switches the 1_16_R2 module to target 1.16.3 rather than 1.16.2, since it's the later version. Also, bumps the minecraft version to compile against for 1_16_R3 and 1_20_R3 modules.

Details

Other abstraction modules target the latest MC version available for a given NMS version, so I've updated 1_16_R2 to reflect that. Because there was a mapping change that affects MobChip between 1.16.2 and 1.16.3, I'm almost certain this would have caused issues when running on 1.16.3 originally, but haven't yet verified that an error occurs when using it.
(Sorry that this is so weird, the original intent for this PR turned out to be unrelated to what this actually fixes 馃檭 )

I'm not aware of any issues arising from the mismatched MC version for 1_16_R3 and 1_20_R3, since both 1.16.5 and 1.20.4 were very minor updates, but those have been changed for completeness.

Tested Environments

OS

OS: Debian 11

Java / Minecraft

MC Builds

  • Tested on Latest 1.16.3 Spigot Version
  • Tested on Latest 1.16.3 Paper / Purpur Version
    (While I did briefly test general functionality, I'm not certain any of the affected code paths were called. Changes do not affect versions other than 1.16.2/3.)

JDK Builds

Tested on:

  • JDK Version 8/11
  • JDK Version 17/18 N/A for 1.16.3

Demonstration

None yet, I will update this if I verify an error occurs on 1.16.3 with previous versions.

@gmitch215
Copy link
Owner

Thanks for the PR. Might use my new GitHub actions runner for testing if I decide to get that set up.

Based on quick research, none should have any significant issues considering both were just bug fixes from the previous version.

@gmitch215 gmitch215 merged commit 377423d into gmitch215:ver/1.9.5 Feb 3, 2024
8 checks passed
@gmitch215 gmitch215 added this to the v1.9.5 milestone Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants