This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
Target 1.16.3 for 1_16_R2; bump mcVersion for 1_16_R3 and 1_20_R3 #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info
This PR switches the 1_16_R2 module to target 1.16.3 rather than 1.16.2, since it's the later version. Also, bumps the minecraft version to compile against for 1_16_R3 and 1_20_R3 modules.
Details
Other abstraction modules target the latest MC version available for a given NMS version, so I've updated 1_16_R2 to reflect that. Because there was a mapping change that affects MobChip between 1.16.2 and 1.16.3, I'm almost certain this would have caused issues when running on 1.16.3 originally, but haven't yet verified that an error occurs when using it.
(Sorry that this is so weird, the original intent for this PR turned out to be unrelated to what this actually fixes 馃檭 )
I'm not aware of any issues arising from the mismatched MC version for 1_16_R3 and 1_20_R3, since both 1.16.5 and 1.20.4 were very minor updates, but those have been changed for completeness.
Tested Environments
OS
OS: Debian 11
Java / Minecraft
MC Builds
Latest1.16.3 Spigot VersionLatest1.16.3 Paper / Purpur Version(While I did briefly test general functionality, I'm not certain any of the affected code paths were called. Changes do not affect versions other than 1.16.2/3.)
JDK Builds
Tested on:
JDK Version 17/18N/A for 1.16.3Demonstration
None yet, I will update this if I verify an error occurs on 1.16.3 with previous versions.