Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS platform tag changes #35

Closed
nightlark opened this issue Oct 19, 2021 · 3 comments
Closed

macOS platform tag changes #35

nightlark opened this issue Oct 19, 2021 · 3 comments

Comments

@nightlark
Copy link
Member

The current HELICS 3.x installers require macos 10.14, so we should update the platform tag in compiled wheels to reflect that (instead of 10.9).

Another upcoming change will be when we start releasing universal macOS binaries, the name of the macOS binary downloaded (and the platform tag) will need updating again. The tags used by the CMake python package are macosx_10_9_universal2.macosx_10_9_x86_64.macosx_11_0_arm64.macosx_11_0_universal2, so we should consider a similar set along the lines of macosx_10_14_universal2.macosx_10_14_x86_64.macosx_11_0_arm64.macosx_11_0_universal2

@trevorhardy
Copy link
Contributor

@nightlark; has this been resolved?

@nightlark
Copy link
Member Author

It seems to be done.

@trevorhardy
Copy link
Contributor

Closing out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants