Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/font2lua: remove golang.org/x/exp usage #18

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

jsleeio
Copy link
Contributor

@jsleeio jsleeio commented Apr 21, 2024

This package isn't being used for anything else here. Replace with inline implementation.

To validate this change I ran gen-lua-fonts.sh at master and for this branch and compared SHA256 digests of all generated Lua files. The digests all matched.

This package isn't being used for anything else here. Replace with
inline implementation.

To validate this change I ran `gen-lua-fonts.sh` at `master` and for
this branch and compared SHA256 digests of all generated Lua files.
The digests all matched.
Copy link
Owner

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jsleeio, but let's please make this a bit more idiomatic Go.

cmd/font2lua/main.go Outdated Show resolved Hide resolved
suggested improvement from @gmlewis. Retested; sha256 digests of generated Lua files match those the base commit (5e26e7d)

Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Copy link
Owner

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jsleeio !
LGTM.
Merging.

@gmlewis gmlewis merged commit ad7994b into gmlewis:master Apr 22, 2024
1 check passed
@jsleeio jsleeio deleted the zap-x-maps branch April 22, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants