Fix AsyncTestCase.published_messages #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation expects all calls to publish_message to be
made with kwargs. Calling publish_message with positional arguments or a
mix of the two results in an exception. For example, `KeyError: 'exchange'`
is raised when the call was made solely with positional arguments. Ex.
self.publish_message('a', 'b', 'c', 'd')
The fixed implmentation simply expands both args and kwargs.
Tested in python 3.7 and 3.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation expects all calls to publish_message to be
made with kwargs. Calling publish_message with positional arguments or a
mix of the two results in an exception. For example,
KeyError: 'exchange'is raised when the call was made solely with positional arguments. Ex.
Specifically, https://github.com/gmr/avroconsumer/blob/master/avroconsumer.py#L85-L87
The fixed implmentation simply expands both args and kwargs.
Tested in python 3.7 and 3.8