Ensure the sub-process exits before the parent process by removing the unref call #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e unref call by using unref, we were introducing a race condition between the parent process exiting and the sub-process exiting - by removing the unref we also remove the race condition as the sub-process will cause the parent process to stay active whilst the sub-process is active. This is likely the correct approach we want to take, if a sub-process is hanging, that is likely an issue the project using cli-testing-library will want to fix as it shows the test is not actually working as they expect it to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by using unref, we were introducing a race condition between the parent process exiting and the sub-process exiting - by removing the unref we also remove the race condition as the sub-process will cause the parent process to stay active whilst the sub-process is active. This is likely the correct approach we want to take, if a sub-process is hanging, that is likely an issue the project using cli-testing-library will want to fix as it shows the test is not actually working as they expect it to.