Make EximsSelector non-abstract

gmrukwa · Apr 26, 2020 · 42ba6a2 · 42ba6a2
1 parent a7e60cd
commit 42ba6a2
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 7 deletions.
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -12,7 +12,7 @@ on:
 env:
   MAJOR: ${{ 2 }}
   MINOR: ${{ 5 }}
-  FIXUP: ${{ 5 }}
+  FIXUP: ${{ 6 }}
   PACKAGE_INIT_FILE: ${{ 'divik/__init__.py' }}
   PACKAGE_INIT_FILE_VERSION_LINE: ${{ 1 }}
   PACKAGE_SETUP_FILE: ${{ 'setup.py' }}

diff --git a/README.md b/README.md
@@ -40,7 +40,7 @@ docker pull gmrukwa/divik
 To install specific version, you can specify it in the command, e.g.:
 
 ```bash
-docker pull gmrukwa/divik:2.5.5
+docker pull gmrukwa/divik:2.5.6
 ```
 
 ## Python package
@@ -79,7 +79,7 @@ pip install divik
 or any stable tagged version, e.g.:
 
 ```bash
-pip install divik==2.5.5
+pip install divik==2.5.6
 ```
 
 If you want to have compatibility with

diff --git a/divik/__init__.py b/divik/__init__.py
@@ -1,4 +1,4 @@
-__version__ = '2.5.5'
+__version__ = '2.5.6'
 
 from ._summary import plot, reject_split
 

diff --git a/divik/feature_selection/_exims/_sklearn.py b/divik/feature_selection/_exims/_sklearn.py
@@ -24,6 +24,18 @@ class EximsSelector(BaseEstimator, SelectorMixin):
     def __init__(self):
         super(EximsSelector, self).__init__()
 
+    def _get_support_mask(self):
+        """
+        Get the boolean mask indicating which features are selected
+
+        Returns
+        -------
+        support : boolean array of shape [# input features]
+            An element is True iff its corresponding feature is selected for
+            retention.
+        """
+        return self.selected_
+
     def fit(self, X, y=None, xy=None):
         """Learn data-driven feature thresholds from X.
 

diff --git a/docs/instructions/installation.rst b/docs/instructions/installation.rst
@@ -14,7 +14,7 @@ To install latest stable version use::
 
 To install specific version, you can specify it in the command, e.g.::
 
-    docker pull gmrukwa/divik:2.5.5
+    docker pull gmrukwa/divik:2.5.6
 
 Python package
 --------------
@@ -31,7 +31,7 @@ package::
 
 or any stable tagged version, e.g.::
 
-    pip install divik==2.5.5
+    pip install divik==2.5.6
 
 If you want to have compatibility with
 `gin-config <https://github.com/google/gin-config>`_, you can install

diff --git a/setup.py b/setup.py
@@ -6,7 +6,7 @@
 import sys
 import numpy
 
-__version__ = '2.5.5'
+__version__ = '2.5.6'
 
 LINUX_OPTS = {
     'extra_link_args': [