Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor parse fns #193

Merged
merged 2 commits into from
Feb 18, 2023
Merged

refactor parse fns #193

merged 2 commits into from
Feb 18, 2023

Conversation

gmsgowtham
Copy link
Owner

@gmsgowtham gmsgowtham commented Feb 18, 2023

  • Remove parseInline methods
  • Create private _parse and _parseToken methods
  • Optimize parser init

@github-actions
Copy link

Performance Comparison Report

Significant Changes To Render Duration

There are no entries

Meaningless Changes To Render Duration

Show entries
Name Render Duration Render Count
Perf test Renders markdown 59.4 ms → 63.1 ms (+3.7 ms, +6.3%) 1 → 1
Show details
Name Render Duration Render Count
Perf test Renders markdown Baseline
Mean: 59.4 ms
Stdev: 2.3 ms (3.8%)
Runs: 63.88613999920199 62.09313499974087 60.45323200081475 59.90163199917879 59.17702900135191 58.71682999987388 58.01342800131533 57.75562799995532 57.326925999775995 56.67742500040913

Current
Mean: 63.1 ms
Stdev: 4.4 ms (6.9%)
Runs: 73.33745500032092 66.30514000036055 64.84313600009773 63.69813600037014 62.46913299954031 62.298331000551116 60.117926999460906 60.09082800068427 59.938130000431556 58.21772599965334
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Changes To Render Count

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against 3bc3979

@gmsgowtham gmsgowtham merged commit 779c568 into main Feb 18, 2023
@gmsgowtham gmsgowtham deleted the remove/inline-parse branch February 18, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant