Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(breaking): markdown hook support #303

Merged
merged 1 commit into from
May 2, 2023
Merged

feat(breaking): markdown hook support #303

merged 1 commit into from
May 2, 2023

Conversation

gmsgowtham
Copy link
Owner

@gmsgowtham gmsgowtham commented May 2, 2023

  • Introduce useMarkdown hook for better extensibility
  • [breaking] Removed container style property

@gmsgowtham gmsgowtham marked this pull request as draft May 2, 2023 10:05
@gmsgowtham gmsgowtham linked an issue May 2, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented May 2, 2023

Performance Comparison Report

  • Current: HEAD (531be96) - 2023-05-02 12:12:08Z
  • Baseline: main (d7de0cc) - 2023-05-02 12:10:53Z

Significant Changes To Render Duration

There are no entries

Meaningless Changes To Render Duration

Show entries
Name Render Duration Render Count
Perf test Renders markdown 92.5 ms → 95.5 ms (+3.0 ms, +3.2%) 1 → 1
Show details
Name Render Duration Render Count
Perf test Renders markdown Baseline
Mean: 92.5 ms
Stdev: 3.0 ms (3.3%)
Runs: 96.64944099981221 96.42564100021264 95.38874100026442 94.22311900078785 92.3413390001806 91.18723899972974 91.04003900001408 89.9787380003254 89.63173800037475 88.12223800006905

Current
Mean: 95.5 ms
Stdev: 4.3 ms (4.5%)
Runs: 104.27867400029209 99.65427200088743 97.95137099944986 96.43626900011441 96.09197000035783 93.71086699992884 92.84906699915882 91.9047650002758 91.1578660000232 90.76256400014972
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Changes To Render Count

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against cb87fda

@gmsgowtham gmsgowtham changed the title __WIP__ feat(breaking): markdown hook support May 2, 2023
@gmsgowtham gmsgowtham marked this pull request as ready for review May 2, 2023 12:06
- Introduce useMarkdown hook for better extensibility
- [breaking] Removed container style property
@gmsgowtham gmsgowtham merged commit 50ece3d into main May 2, 2023
@gmsgowtham gmsgowtham deleted the feat/md-hook branch May 2, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for custom wrapper
1 participant