Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link or button ? #25

Open
ghost opened this issue Aug 18, 2015 · 2 comments
Open

Link or button ? #25

ghost opened this issue Aug 18, 2015 · 2 comments

Comments

@ghost
Copy link

ghost commented Aug 18, 2015

Hello,

I would like to subject(submit) you a detail by the fact that it has an importance for the French translation.

It is about the links "Set active" at the bottom of columns.
ref : https://github.com/gn36/phpbb-ext-hookup/blob/master/styles/prosilver/template/viewtopic_hookup.html#L139

In view of the importance of the irreversible action(share) which it engenders, would not it be better to replace this link by a button ?

(translate French/English by http://www.reverso.net)

Thank you

@gn36
Copy link
Owner

gn36 commented Aug 18, 2015

There still is the confirmation page in between the irreversible action and the click on the link, the link itself only leads to the confirmation page.

There is far more direct changes to the database in phpBB, which are links and don't even use a confirmation page, such as "mark all forums as read". I thought of this link as being similar to basically all "delete post" and "delete pm" links, which - even though they look like buttons - still are links.

So I don't think I would change the links to buttons, but if you can come up with an image similar to the button images used for deletion, reporting or quoting a post, that fits this link better, I guess we could style up the link a bit more.

@ghost
Copy link
Author

ghost commented Aug 18, 2015

(It is difficult to explain everything through an interface of translation to communicate)

To summarize, no button but possibly an image "Pictogram", ok.

I fetch an idea this way ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant