Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update src/jquery.requestAnimationFrame.js #1

Closed
wants to merge 1 commit into from
Closed

Update src/jquery.requestAnimationFrame.js #1

wants to merge 1 commit into from

Conversation

1Marc
Copy link

@1Marc 1Marc commented Aug 27, 2012

Use the updated requestAnimationFrame polyfill
https://gist.github.com/1579671

Use the updated requestAnimationFrame polyfill
https://gist.github.com/1579671
@gnarf
Copy link
Owner

gnarf commented Aug 27, 2012

I really don't like the idea of shimming a setTimeout version of requestAnimationFrame in the jQuery plugin. It shouldn't bother overriding the setTimeout loop if there is no requestAnimationFrame.

I wasn't even going to shim window.requestAnimationFrame but someone suggested it might be good to do so.

Thoughts @paulirish?

@paulirish
Copy link
Contributor

the improved polyfill is definitely better. i would recommend using it.

i'm on the fence as to if jquery-rAF should polyfill the global, but right now it seems fine.

basically it the polyfill as a .js plus some jquery bindings.

i like it.

do it.

👍

@gnarf gnarf closed this in a8ca204 Aug 31, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants