Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer usage in status reports #3

Closed
chamnit opened this issue Sep 25, 2016 · 2 comments
Closed

Buffer usage in status reports #3

chamnit opened this issue Sep 25, 2016 · 2 comments

Comments

@chamnit
Copy link
Contributor

chamnit commented Sep 25, 2016

@vlachoudis brought up a point that the status report buffer usage should state number of bytes and blocks free, rather than in use. Doing it this way, doesn't require knowing how big the buffer is.

After asking around, it doesn't seem like anyone uses the buffer state and don't have a reason to. The one instance that I know its being used heavily is made obsolete by introducing the new jogging mode to v1.1.

I propose to disable buffer usage by default, make it available for re-enable via settings mask, and tweak it to say available, not used. This is generally only useful for debugging an interface and doesn't need to take up serial TX bandwidth unless there is a good reason. Does anyone?

@gerritv
Copy link

gerritv commented Sep 25, 2016

Ok with me to make it optional, for me it was only used when people (the laser users mostly) complained about jerky motion to isolate the cause.

@chamnit
Copy link
Contributor Author

chamnit commented Sep 27, 2016

Last night's v1.1b push changed the buffer state to show bytes and blocks available, rather than in use. It has been disabled by default, but maybe enabled via the $10 report mask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants