Handle case class defaults better #612
Open
+60
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always parse empty cells to their default values if one is defined, allowing to use defaults with types that can't be parsed from an empty cell, like numbers. Comes at the expense of not being able to parse empty cells as-is any longer if a default exist. Closes #607
ybasket
commented
Jun 23, 2024
| } | ||
|
|
||
| pureTest("case classes should be handled properly with default string value and empty cell") { | ||
| expect(testDefaultsDecoder(csvRowEmptyJ) == Right(TestDefaults(1, "foo"))) |
There was a problem hiding this comment.
Note that the default "foo" is expected even though a String cell could handle the empty cell. While I think it's the better behaviour for users as they now can handle Int or any other type that can't be parsed from empty input via default, it is a change that we should highlight in the release notes. Users that need to handle empty cells may no longer define a default (except for "" itself) for those in their case class.
There was a problem hiding this comment.
Thinking about it, I would add a clear note in the documentation for this caveat.
satabin
reviewed
Jun 24, 2024
| @@ -74,6 +74,7 @@ private[generic] trait LowPriorityMapShapedCsvRowDecoder1 { | |||
| default: Option[Head] :: DefaultTail, | |||
| anno: Anno :: AnnoTail): DecoderResult[FieldType[Key, Head] :: Tail] = { | |||
| val head = row(anno.head.fold(witness.value.name)(_.name)) match { | |||
| case Some(head) if head.isEmpty && default.head.nonEmpty => default.head.get.asRight | |||
There was a problem hiding this comment.
I'd love to avoid the .get if possible. Something like:
Suggested change
| case Some(head) if head.isEmpty && default.head.nonEmpty => default.head.get.asRight | |
| case Some(head) if head.isEmpty && default.head.nonEmpty => default.head.toRight(new DecoderError("Should not happen", row.line)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always parse empty cells to their default values if one is defined, allowing to use defaults with types that can't be parsed from an empty cell, like numbers. Comes at the expense of not being able to parse empty cells as-is any longer if a default exist.
Closes #607